Add a boolean 'addWatermarking' attribute to taskprocessing tasks#56717
Merged
AndyScherzinger merged 1 commit intomasterfrom Nov 28, 2025
Merged
Add a boolean 'addWatermarking' attribute to taskprocessing tasks#56717AndyScherzinger merged 1 commit intomasterfrom
AndyScherzinger merged 1 commit intomasterfrom
Conversation
julien-nc
added
enhancement
2. developing
julien-nc
force-pushed
the
enh/noid/taskpro-optional-watermarking
branch
from
f0f20ca to
d43d071
Compare
Member
ExApp may need this, though |
marcelklehr
reviewed
Nov 26, 2025
| if ($schema->hasTable('taskprocessing_tasks')) { | ||
| $table = $schema->getTable('taskprocessing_tasks'); | ||
| if (!$table->hasColumn('add_watermarking')) { | ||
| $table->addColumn('add_watermarking', Types::SMALLINT, [ |
Member
There was a problem hiding this comment.
Nitpick: How about enable_watermarking or apply_watermark or include_watermark?
getAddWatermark() sounds a bit odd. 🤔
julien-nc
force-pushed
the
enh/noid/taskpro-optional-watermarking
branch
from
d43d071 to
9eca93c
Compare
julien-nc
force-pushed
the
enh/noid/taskpro-optional-watermarking
branch
2 times, most recently
from
a9c5926 to
8d0401f
Compare
Member
Author
|
marcelklehr
approved these changes
Nov 27, 2025
…ing tasks and pass it to ISynchronousWatermarkingProvider::process Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/taskpro-optional-watermarking
branch
from
8d0401f to
b4f7fe2
Compare
julien-nc
requested review from
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
AndyScherzinger
added
4. to release
susnux
added
the
pending documentation
Contributor
|
New added interface (public API) in OCP need to be mentioned here: |
marcelklehr
added a commit
to nextcloud/documentation
that referenced
this pull request
Feb 2, 2026
see nextcloud/server#56908 see nextcloud/server#56717 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
backportbot bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Feb 2, 2026
see nextcloud/server#56908 see nextcloud/server#56717 Signed-off-by: Marcel Klehr <mklehr@gmx.net> [skip ci]
marcelklehr
added a commit
to nextcloud/documentation
that referenced
this pull request
Feb 19, 2026
see nextcloud/server#56908 see nextcloud/server#56717 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be useful when scheduling internal intermediate tasks for which we don't want watermarking.
When tasks are scheduled via the OCS API, watermarking is always enabled.
@marcelklehr We can't change the signature of ISynchronousProvider::process without making sure all the providers are compatible with the new signature (which is impossible). So for now I pass an extra param when calling it.