Skip to content

Comments

feat(TaskProcessing): Add OCR TaskType#56908

Merged
kesselb merged 1 commit intomasterfrom
feat/tasktype-ocr
Dec 8, 2025
Merged

feat(TaskProcessing): Add OCR TaskType#56908
kesselb merged 1 commit intomasterfrom
feat/tasktype-ocr

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Dec 8, 2025

Summary

Adds a task processing task type for doing OCR

TODO

  • Ideas for more inputs?

Checklist

@marcelklehr marcelklehr added this to the Nextcloud 33 milestone Dec 8, 2025
@marcelklehr marcelklehr requested a review from a team as a code owner December 8, 2025 11:40
@marcelklehr marcelklehr added the 3. to review Waiting for reviews label Dec 8, 2025
@marcelklehr marcelklehr requested review from ArtificialOwl, CarlSchwan, icewind1991, julien-nc, kyteinsky and leftybournes and removed request for a team December 8, 2025 11:40
@marcelklehr marcelklehr requested a review from janepie December 8, 2025 12:34
@janepie
Copy link
Member

janepie commented Dec 8, 2025

Looks good! We could add an input for the language to be extracted and have it default to automatic detection, or add that as optional input only for providers that make use of it. Both fine for me, wdyt @julien-nc @kyteinsky ?

@julien-nc
Copy link
Member

julien-nc commented Dec 8, 2025

Not sure the OCR libraries take a "language" param to help them perform an optimal extraction. @marcelklehr Do they?
If so, I'm ok with adding an input field. It's also fine to let the providers add an optional one as not all the providers might support the param.

@marcelklehr
Copy link
Member Author

marcelklehr commented Dec 8, 2025

Not sure the OCR libraries take a "language" param to help them perform an optimal extraction. @marcelklehr Do they?

The latest models don't require a language input, but older libraries like tesseract may require this. I think an optional input is fine.

@marcelklehr marcelklehr enabled auto-merge December 8, 2025 13:49
@marcelklehr
feat(TaskProcessing): Add OCR TaskType
3355e6a 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@kesselb kesselb disabled auto-merge December 8, 2025 16:45
@kesselb kesselb merged commit b7b4a3a into master Dec 8, 2025
173 of 179 checks passed
@kesselb kesselb deleted the feat/tasktype-ocr branch December 8, 2025 16:53
kyteinsky
kyteinsky reviewed Dec 9, 2025
View reviewed changes
lib/public/TaskProcessing/TaskTypes/ImageToTextOpticalCharacterRecognition.php
Comment on lines +65 to +73
public function getInputShape(): array {
return [
'input' => new ShapeDescriptor(
$this->l->t('Input Image'),
$this->l->t('The image to extract text from'),
EShapeType::Image
),
];
}
Copy link
Contributor

@kyteinsky kyteinsky Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if it were a ListOfFiles so it can accept images and pdfs both, and multiple of them instead of a single one for a single task, which also keeps the task list shorter in the DB.

@susnux susnux added the pending documentation This pull request needs an associated documentation update label Jan 28, 2026
@susnux
Copy link
Contributor

susnux commented Jan 28, 2026

New public API (interface and classes in OCP) need to be mentioned here:
https://github.com/nextcloud/documentation/blob/1a0415c8bf1541e90ae0b4da487a362a51a1cfe2/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_33.rst?plain=1#L184

marcelklehr added a commit to nextcloud/documentation that referenced this pull request Feb 2, 2026
@marcelklehr
fix(developer_manual): Add TaskProcessing updates to 33 upgrade guide
f0c1a6f 
 see nextcloud/server#56908

 see nextcloud/server#56717

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr mentioned this pull request Feb 2, 2026
Merged
backportbot bot pushed a commit to nextcloud/documentation that referenced this pull request Feb 2, 2026
@marcelklehr @backportbot
fix(developer_manual): Add TaskProcessing updates to 33 upgrade guide
c31c4ea 
see nextcloud/server#56908

see nextcloud/server#56717

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

[skip ci]
marcelklehr added a commit to nextcloud/documentation that referenced this pull request Feb 19, 2026
@marcelklehr
fix(developer_manual): Add TaskProcessing updates to 33 upgrade guide
17128a7 
see nextcloud/server#56908

see nextcloud/server#56717

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyteinsky kyteinsky kyteinsky left review comments

@julien-nc julien-nc julien-nc approved these changes

@janepie janepie janepie approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: TaskProcessing pending documentation This pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@marcelklehr @janepie @julien-nc @susnux @kyteinsky @kesselb