Skip to content

Comments

🌐 i10n Add notes for maths dialog translations#7965

Merged
mejo- merged 6 commits intonextcloud:mainfrom
moodyjmz:add-translator-notes-for-maths
Nov 24, 2025
Merged

🌐 i10n Add notes for maths dialog translations#7965
mejo- merged 6 commits intonextcloud:mainfrom
moodyjmz:add-translator-notes-for-maths

Conversation

@moodyjmz
Copy link
Contributor

@moodyjmz moodyjmz commented Nov 21, 2025

📝 Summary

Added notes for translators to better understand the context of what they are translating

I have added the notes slightly above as I got linter warnings when I added them next to the content as the content is in a tenary

I also changed the text from Display >>> Block as it better matches how the content is displayed, ie inline or block

🖼️ Screenshots

N/A

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@rakekniven
Copy link
Member

I do not think this will work and the text will be displayed at Transifex.
@nickvergessen Your opinion?

@moodyjmz moodyjmz force-pushed the add-translator-notes-for-maths branch from 7bfbe68 to b433fbe Compare November 22, 2025 14:32
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Math/ShowMathModal.vue 0.00% 3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…d linting warnings

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…anslators

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…t is being changed

Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
@mejo- mejo- force-pushed the add-translator-notes-for-maths branch from 0db74d1 to 9493854 Compare November 24, 2025 11:33
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
@mejo- mejo- merged commit 6287fe0 into nextcloud:main Nov 24, 2025
63 of 64 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: Need context and grammar needs to be fixed

4 participants