Update to Firefox 134 and migrate back to conda#1109
Merged
Conversation
…conda env The --force flag was deprecated and replaces by --yes which is currently undocumented conda/conda#13704 This fix makes use of the new functionality
vringar
approved these changes
Jan 16, 2025
Contributor
vringar
left a comment
There was a problem hiding this comment.
Added back the ability to rerun our conda modifying scripts (repin and install) without having to first delete the openwpm environment
Everything else looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #1105, mamba has been merged upstream into conda. Looks like as of 2025 they've fully deprecated it and stopped building the mamba binaries.
I replaced all references to mamba with conda and things "just work" both locally and on the CI tests, so I think we're all good.