Conversation
Sort out the RefCount type (ty @dvc94ch) Random tweaks to make test-node more similar to the vanilla node-template
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM, just needs master merging.
|
The integration tests fail for me. I am checking if this is due to an outdated Polkadot. |
Co-authored-by: Demi Marie Obenour <demiobenour@gmail.com>
* master: Remove unnecessary Sync requirements (#172)
…te-subxt into dp-prep-release-v0.13 * 'dp-prep-release-v0.13' of github.com:paritytech/substrate-subxt: Update test-node/runtime/src/lib.rs
Co-authored-by: Demi Marie Obenour <demiobenour@gmail.com>
Can you be more specific? All of them? How did you run them? One by one? All at once? Which node type did you try and how did you start it, full command? |
|
It was due to an old version of polkadot. The tests pass with git master.
|
|
Don't follow. Which chain do you mean? Polkadot, kusama, edgeware, sunshine or some other chain? |
|
@dvc94ch Polkadot and Kusama |
|
So are they guaranteed to be updated at the same time? I don't see what the deployment has to do with merging this pr. If you want to treat those chains specially, you can add branches for them, but really it's the responsibility of people building with subxt for a specific chain to make sure they have a combination that works. |
I don't think it's blocker, we don't need our releases to be in sync with what is deployed on any particular chain. We will make releases which are compatible with new versions of substrate as they come along, and people will choose whichever release matches their target chain. This will be better now substrate has proper versioning (no longer pre-release), so we can track them. |
Yeah, my bad. I had |
|
I don't know when the upgrade for substrate 2.0 is planned for kusama/polkadot, but it surely is soon. In the meantime you could always craft an intermediate release with |
4 participants
Based on #173 – only 1c3cf61 is new here.
Version 0.13.0