Skip to content

Comments

feat: allow GraphIQL headers#1836

Merged
mtrezza merged 14 commits intoparse-community:alphafrom
dblythy:fix-graphql-headers
Oct 8, 2021
Merged

feat: allow GraphIQL headers#1836
mtrezza merged 14 commits intoparse-community:alphafrom
dblythy:fix-graphql-headers

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented Oct 6, 2021

New Pull Request Checklist

Issue Description

New GraphIQL viewer doesn't allow header configuration

Related issue: #1834

Approach

Adds header editor to GraphIQL

Screen Shot 2021-10-07 at 12 26 56 am

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 6, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 7, 2021

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: Allow GraphIQL headers feat: allow GraphIQL headers Oct 7, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2021

This is not yet ready for review, right?

@dblythy
Copy link
Member Author

dblythy commented Oct 8, 2021

@mtrezza it is ready for review, are you expecting something else? GraphIQL already supports headers so it's pretty simple to enable them.

@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2021

Great, will take a look! I was just asking because no review was requested but it seemed already finished.

@dblythy
Copy link
Member Author

dblythy commented Oct 8, 2021

No worries, I understand you take on a lot across the repos so I’m always conscious not to be demanding and “request” you review my PRs. I appreciate you have a lot of commitments and will get to things when you can. If something isn’t ready, I’ll mark it as draft 😊

@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2021 •
edited
Loading

I am actually specifically looking for PRs to merge here to test and refine release automation. So whenever there is a PR ready for review, just feel free to request in any repo.

You are making a good point regarding how we can use the draft state of PRs. Let me open an issue for discussion.

@mtrezza mtrezza self-requested a review October 8, 2021 11:47
@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2021

@axelhildingson could you test this feature and see if it works as you suggested in #1834?

@mtrezza mtrezza merged commit 3afcf73 into parse-community:alpha Oct 8, 2021
@mtrezza mtrezza mentioned this pull request Oct 8, 2021
Closed
parseplatformorg pushed a commit that referenced this pull request Oct 8, 2021
@semantic-release-bot
chore(release): 3.3.0-alpha.1 [skip ci]
eff7d5a 
# [3.3.0-alpha.1](3.2.1-alpha.1...3.3.0-alpha.1) (2021-10-08)

### Features

* allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73))
* allow graphQL headers ([34536b3](34536b3))

### Reverts

* Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Oct 8, 2021

🎉 This pull request has been released in version 3.3.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 8, 2021
@dblythy dblythy deleted the fix-graphql-headers branch October 9, 2021 01:44
parseplatformorg pushed a commit that referenced this pull request Nov 1, 2021
@semantic-release-bot
chore(release): 3.3.0-beta.1 [skip ci]
3ec64c3 
# [3.3.0-beta.1](3.2.1-beta.1...3.3.0-beta.1) (2021-11-01)

### Bug Fixes

* always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59))
* app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6))
* link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d))
* manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b))
* notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6))
* upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14))
* upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e))
* upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335))
* upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0))
* upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0))

### Features

* add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1))
* add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786))
* add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e))
* allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73))
* allow graphQL headers ([34536b3](34536b3))

### Reverts

* Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Nov 1, 2021

🎉 This change has been released in version 3.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
parseplatformorg pushed a commit that referenced this pull request Jan 1, 2022
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
b8226a2 
# [3.3.0](3.2.1...3.3.0) (2022-01-01)

### Bug Fixes

* always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59))
* app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6))
* bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([35fd021](35fd021))
* context menu in data browser not opening for cell of type number ([#1913](#1913)) ([8731c35](8731c35))
* link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d))
* manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b))
* notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6))
* upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14))
* upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e))
* upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335))
* upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0))
* upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0))

### Features

* add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1))
* add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786))
* add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e))
* allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73))
* allow graphQL headers ([34536b3](34536b3))

### Reverts

* Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jan 1, 2022

🎉 This change has been released in version 3.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza Awaiting requested review from mtrezza

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dblythy @mtrezza @parseplatformorg