Skip to content

Comments

fix: context menu in data browser not opening for cell of type number#1913

Merged
mtrezza merged 2 commits intoparse-community:alphafrom
404-html:fix-context-menu-for-numbers
Nov 2, 2021
Merged

fix: context menu in data browser not opening for cell of type number#1913
mtrezza merged 2 commits intoparse-community:alphafrom
404-html:fix-context-menu-for-numbers

Conversation

@404-html
Copy link
Member

@404-html 404-html commented Nov 1, 2021 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

Problem introduced here, new code assumes that this.copyableValue will be always a string.

Related issue: #1914

Approach

Converting copyableValue into string before processing.
I've also addressed react key warning on context menu.

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 1, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented Nov 1, 2021

Could you please create an issue for this to describe what the actual issue is?

@404-html 404-html requested a review from mtrezza November 2, 2021 08:01
@mtrezza mtrezza linked an issue Nov 2, 2021 that may be closed by this pull request
Context menu not working for Number type of cells #1914
Closed
4 tasks
mtrezza
mtrezza approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this!

@mtrezza mtrezza changed the title fix: context menu not working when clicking on a cell with number fix: context menu not opening for cell of type number Nov 2, 2021
@mtrezza mtrezza changed the title fix: context menu not opening for cell of type number fix: context menu in data browser not opening for cell of type number Nov 2, 2021
@mtrezza mtrezza merged commit fb0e3a9 into parse-community:alpha Nov 2, 2021
parseplatformorg pushed a commit that referenced this pull request Nov 2, 2021
@semantic-release-bot
chore(release): 3.3.0-alpha.15 [skip ci]
2ca5d81 
# [3.3.0-alpha.15](3.3.0-alpha.14...3.3.0-alpha.15) (2021-11-02)

### Bug Fixes

* context menu in data browser not opening for cell of type number ([#1913](#1913)) ([fb0e3a9](fb0e3a9))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Nov 2, 2021

🎉 This change has been released in version 3.3.0-alpha.15

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 2, 2021
mtrezza pushed a commit that referenced this pull request Nov 2, 2021
@404-html @mtrezza
fix: context menu in data browser not opening for cell of type number (…
8731c35 
…#1913)
parseplatformorg pushed a commit that referenced this pull request Nov 2, 2021
@semantic-release-bot
chore(release): 3.3.0-beta.2 [skip ci]
2669693 
# [3.3.0-beta.2](3.3.0-beta.1...3.3.0-beta.2) (2021-11-02)

### Bug Fixes

* context menu in data browser not opening for cell of type number ([#1913](#1913)) ([8731c35](8731c35))
parseplatformorg pushed a commit that referenced this pull request Jan 1, 2022
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
b8226a2 
# [3.3.0](3.2.1...3.3.0) (2022-01-01)

### Bug Fixes

* always pass boolean value when toggling checkbox ([#1872](#1872)) ([2e9fd59](2e9fd59))
* app icons are cropped in the app list for small screen sizes ([#1876](#1876)) ([9fc56a6](9fc56a6))
* bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([35fd021](35fd021))
* context menu in data browser not opening for cell of type number ([#1913](#1913)) ([8731c35](8731c35))
* link icon in pointer cell not visible when cell is too narrow ([#1856](#1856)) ([69b897d](69b897d))
* manual column preferences are overwritten by columnPreference option on page refresh ([#1881](#1881)) ([7232b0b](7232b0b))
* notification to upgrade dashboard for latest features not working ([#1894](#1894)) ([81361b6](81361b6))
* upgrade graphql from 15.4.0 to 15.6.0 ([#1853](#1853)) ([fca9b14](fca9b14))
* upgrade graphql from 15.6.0 to 15.6.1 ([#1887](#1887)) ([0cfe59e](0cfe59e))
* upgrade inquirer from 8.1.3 to 8.2.0 ([#1886](#1886)) ([c77f335](c77f335))
* upgrade passport from 0.4.1 to 0.5.0 ([#1865](#1865)) ([8d845f0](8d845f0))
* upload of file as default value fails when adding a new column ([#1875](#1875)) ([6040dd0](6040dd0))

### Features

* add config option `columnPreference.filterSortToTop` to set column name order in filter dialog ([#1884](#1884)) ([3acbda1](3acbda1))
* add pointer representation by a chosen column instead of objectId ([#1852](#1852)) ([d747786](d747786))
* add visual distinction in data browser for internal classes and display their real names with underscore ([#1878](#1878)) ([ac8d85e](ac8d85e))
* allow GraphIQL headers ([#1836](#1836)) ([3afcf73](3afcf73))
* allow graphQL headers ([34536b3](34536b3))

### Reverts

* Revert "Update CloudCode.react.js" ([eea1e2d](eea1e2d))
parseplatformorg pushed a commit that referenced this pull request Jan 1, 2022
@semantic-release-bot
chore(release): 4.0.0-beta.1 [skip ci]
98cf0ee 
# [4.0.0-beta.1](3.3.0-beta.3...4.0.0-beta.1) (2022-01-01)

### Bug Fixes

* bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([26c0dfa](26c0dfa))
* context menu in data browser not opening for cell of type number ([#1913](#1913)) ([fb0e3a9](fb0e3a9))
* opening filter menu in data browser leads to blank page ([#1958](#1958)) ([750e8b1](750e8b1))
* saving relation column fails if class has required fields ([#1937](#1937)) ([c67db08](c67db08))
* security upgrade qrcode from 1.4.4 to 1.5.0 ([#1930](#1930)) ([244e1bb](244e1bb))

### Features

* upgrade graphiql from 1.4.7 to 1.5.1 ([#1943](#1943)) ([ebb1f66](ebb1f66))
* upgrade graphql from 15.7.0 to 16.0.0 ([#1926](#1926)) ([7c94e51](7c94e51))
* upgrade parse from 3.3.1 to 3.4.0 ([#1942](#1942)) ([13a250e](13a250e))

### BREAKING CHANGES

* The minimum required Node.js version is 12.22.0. ([7c94e51](7c94e51))
* The required Node version was increased to >=12.20.0. ([ebb1f66](ebb1f66))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jan 1, 2022

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 1, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Jan 2, 2022
@cycqitianwushuge
Merge branch 'release'
5ca04ae 
* release: (75 commits)
  chore(release): 3.3.0 [skip ci]
  ci: release commit
  chore(release): 3.3.0-beta.3 [skip ci]
  fix: bump graphiql from 1.4.6 to 1.4.7 (parse-community#1920)
  chore(release): 3.3.0-beta.2 [skip ci]
  fix: context menu in data browser not opening for cell of type number (parse-community#1913)
  chore(release): 3.3.0-beta.1 [skip ci]
  build: release (parse-community#1911)
  ci: release commit
  test: update outdated tests, remove unnecessary `NODE_PATH` passed to jest (parse-community#1910)
  refactor: update webpack to latest version (parse-community#1908)
  refactor: update graphiql to latest version (parse-community#1907)
  refactor: update react-helmet to latest version (parse-community#1906)
  refactor: update package-json to latest version (parse-community#1904)
  refactor: update http-server to latest version (parse-community#1903)
  refactor: upgrade react-popper-tooltip from 4.3.0 to 4.3.1 (parse-community#1901)
  refactor: upgrade immutable from 4.0.0-rc.9 to 4.0.0 (parse-community#1900)
  chore(release): 3.3.0-alpha.14 [skip ci]
  fix: notification to upgrade dashboard for latest features not working (parse-community#1894)
  refactor: update copy-to-clipboard to latest version (parse-community#1888)
  ...

# Conflicts:
#	package-lock.json
parseplatformorg pushed a commit that referenced this pull request Feb 6, 2022
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
663762f 
# [4.0.0](3.3.0...4.0.0) (2022-02-06)

### Bug Fixes

* bump graphiql from 1.4.6 to 1.4.7 ([#1920](#1920)) ([26c0dfa](26c0dfa))
* context menu in data browser not opening for cell of type number ([#1913](#1913)) ([fb0e3a9](fb0e3a9))
* opening filter menu in data browser leads to blank page ([#1958](#1958)) ([750e8b1](750e8b1))
* saving relation column fails if class has required fields ([#1937](#1937)) ([c67db08](c67db08))
* security upgrade qrcode from 1.4.4 to 1.5.0 ([#1930](#1930)) ([244e1bb](244e1bb))
* various UI bugs (e.g. filter data browser, switch app, upload file) ([#2014](#2014)) ([785978e](785978e))

### Features

* upgrade graphiql from 1.4.7 to 1.5.1 ([#1943](#1943)) ([ebb1f66](ebb1f66))
* upgrade graphql from 15.7.0 to 16.0.0 ([#1926](#1926)) ([7c94e51](7c94e51))
* upgrade parse from 3.3.1 to 3.4.0 ([#1942](#1942)) ([13a250e](13a250e))

### BREAKING CHANGES

* The minimum required Node.js version is 12.22.0. ([7c94e51](7c94e51))
* The required Node version was increased to >=12.20.0. ([ebb1f66](ebb1f66))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Feb 6, 2022

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Context menu not working for Number type of cells

3 participants

@404-html @mtrezza @parseplatformorg