Skip to content

fix: Uncaught error when editing Number field in Edit Row dialog#2401

Merged
mtrezza merged 1 commit intoparse-community:alphafrom
dplewis:fix-number-editor
Mar 5, 2023
Merged

fix: Uncaught error when editing Number field in Edit Row dialog#2401
mtrezza merged 1 commit intoparse-community:alphafrom
dplewis:fix-number-editor

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Mar 5, 2023

New Pull Request Checklist

Issue Description

Uncaught (in promise) Error: Maximum update depth exceeded. is called when typing an empty field or non alpha numberic characters.

Closes: #2324

Approach

  • Allow clearing number field (undefined)
  • Prevent non numberic characters from being entered

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 5, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dplewis dplewis requested review from dblythy and mtrezza March 5, 2023 02:38
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Mar 5, 2023

Uffizzi Ephemeral Environment deployment-18152

⌚ Updated Mar 05, 2023, 02:37 UTC

☁️ https://pr-2401-deployment-18152-parse-dashboard.app.uffizzi.com

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza changed the title fix: Crashing when editing Number field in Edit Row Modal fix: Uncaught error when editing Number field in Edit Row dialog Mar 5, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 26bd6fa into parse-community:alpha Mar 5, 2023
parseplatformorg pushed a commit that referenced this pull request Mar 5, 2023
# [5.1.0-alpha.12](5.1.0-alpha.11...5.1.0-alpha.12) (2023-03-05)

### Bug Fixes

* Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.12

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 5, 2023
@dplewis dplewis deleted the fix-number-editor branch March 6, 2023 21:28
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
# [5.2.0-beta.1](5.1.0...5.2.0-beta.1) (2023-05-01)

### Bug Fixes

* Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa))

### Features

* Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b))
* Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 1, 2023
parseplatformorg pushed a commit that referenced this pull request May 21, 2023
# [5.2.0-alpha.1](5.1.0...5.2.0-alpha.1) (2023-05-21)

### Bug Fixes

* Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa))

### Features

* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
* Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b))
* Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.1

parseplatformorg pushed a commit that referenced this pull request Sep 15, 2023
# [5.2.0](5.1.0...5.2.0) (2023-09-15)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))
* Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa))

### Features

* Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946))
* Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))
* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
* Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b))
* Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard crashes when editing row with modal

3 participants