Skip to content

fix: Empty table in data browser when navigating back using the "back” button#2423

Merged
mtrezza merged 2 commits intoparse-community:alphafrom
patelmilanun:no-data-back-button-fix
May 27, 2023
Merged

fix: Empty table in data browser when navigating back using the "back” button#2423
mtrezza merged 2 commits intoparse-community:alphafrom
patelmilanun:no-data-back-button-fix

Conversation

@patelmilanun
Copy link
Member

@patelmilanun patelmilanun commented Apr 14, 2023 •
edited
Loading

New Pull Request Checklist

Issue Description

when u visit inner class from any field of type relation u can get a back button to fall back to parent class but here it was not fetching that data and rather showing the old data.

Closes: #2415

Approach

The current check was not checking for the condition for fetching and updating the data for a type of relation. As the parent class is same for old as well as the new screen, when transitioning we are getting same class name and thus not updating. So I added the condition for relation as well.

TODOs before merging

None

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 14, 2023

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: showing no data when hitting back icon fix: Showing no data when hitting back icon Apr 14, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 14, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@patelmilanun patelmilanun changed the title fix: Showing no data when hitting back icon fix: Showing old data when hitting back button Apr 14, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Apr 14, 2023

Uffizzi Ephemeral Environment deployment-22322

⌚ Updated Apr 14, 2023, 20:19 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2423

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza requested a review from a team April 15, 2023 14:05
@mtrezza mtrezza changed the title fix: Showing old data when hitting back button fix: Previous data is not shown when navigating back using the "back” button Apr 15, 2023
@mtrezza mtrezza changed the title fix: Previous data is not shown when navigating back using the "back” button fix: Previous data is not shown in data browser when navigating back using the "back” button Apr 15, 2023
@mtrezza mtrezza changed the title fix: Previous data is not shown in data browser when navigating back using the "back” button fix: Data is not shown in data browser when navigating back using the "back” button Apr 15, 2023
@mtrezza mtrezza changed the title fix: Data is not shown in data browser when navigating back using the "back” button fix: Empty table in data browser when navigating back using the "back” button May 27, 2023
mtrezza
mtrezza approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 6f3dab6 into parse-community:alpha May 27, 2023
parseplatformorg pushed a commit that referenced this pull request May 27, 2023
@semantic-release-bot
chore(release): 5.2.0-alpha.3 [skip ci]
9dc8dab 
# [5.2.0-alpha.3](5.2.0-alpha.2...5.2.0-alpha.3) (2023-05-27)

### Bug Fixes

* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented May 27, 2023

🎉 This change has been released in version 5.2.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 27, 2023
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
4f8e35e 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
a880b1a 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 8, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
ecfcd03 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-08)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
parseplatformorg pushed a commit that referenced this pull request Jun 10, 2023
@semantic-release-bot
chore(release): 5.2.0-beta.2 [skip ci]
057fc8b 
# [5.2.0-beta.2](5.2.0-beta.1...5.2.0-beta.2) (2023-06-10)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))

### Features

* Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946))
* Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))
* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jun 10, 2023

🎉 This change has been released in version 5.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 5.2.0 [skip ci]
5b85740 
# [5.2.0](5.1.0...5.2.0) (2023-09-15)

### Bug Fixes

* Back button in data browser disappears after page refresh ([#2421](#2421)) ([6c5f19f](6c5f19f))
* Cannot navigate to nested relation field in data browser ([#2420](#2420)) ([e7ace9e](e7ace9e))
* Dashboard crashes when adding a row with modal in a class that contains a pointer to another class that contains an array of pointers ([#2416](#2416)) ([286269f](286269f))
* Empty table in data browser when navigating back using the "back” button ([#2423](#2423)) ([6f3dab6](6f3dab6))
* File uploading status not updating in data browser ([#2422](#2422)) ([e761f97](e761f97))
* Hitting backspace key in data browser crashes dashboard ([#2456](#2456)) ([32aeea2](32aeea2))
* Incorrect date picker position in data browser filter dialog ([#2425](#2425)) ([b96b48f](b96b48f))
* Option missing for Parse Config parameter to require master key ([#2440](#2440)) ([6623369](6623369))
* Scroll position is preserved when re-opening the same class in data browser via navigation bar ([#2445](#2445)) ([667675c](667675c))
* Text input cursor jumps to first position when writing long text ([#2413](#2413)) ([422ffb2](422ffb2))
* Uncaught error when editing Number field in Edit Row dialog ([#2401](#2401)) ([26bd6fa](26bd6fa))

### Features

* Add export of saved data browser filters via `classPreference` settings ([#2455](#2455)) ([f56f946](f56f946))
* Add filter views to save frequently used filters in data browser ([#2404](#2404)) ([a9ec3a9](a9ec3a9))
* Add links to users and roles in ACL dialog and handle invalid entries ([#2436](#2436)) ([a20cb8e](a20cb8e))
* Add visual configurator for Parse Dashboard settings ([#2406](#2406)) ([228d839](228d839))
* Data types and pointer classes are sorted alphabetically in dialog to add new column ([#2400](#2400)) ([d9d285b](d9d285b))
* Sort Cloud Code Jobs alphabetically ([#2402](#2402)) ([77fc372](77fc372))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Sep 15, 2023

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

+1 more reviewer

@AshishBarvaliya AshishBarvaliya AshishBarvaliya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Showing "No data to display" for the _Role section, even though there are Roles present.

4 participants

@patelmilanun @parseplatformorg @mtrezza @AshishBarvaliya