storage: add profile flag#453
storage: add profile flag#453igungor merged 17 commits intopeak:masterfrom kucukaslan:add-profile-flag
Conversation
kucukaslan
requested review from
aykutfarsak and
ilkinulas
and removed request for
a team
The comment just just repeats what code says.
… read credentials from. This commit adds credential-file flag to allow users to specify credential file to read credentials from rather than using the default. See also [Configuration and credential file settings](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html) Updates #453.
|
I've created a new branch based on add-profile-flag branch to add If you agree I can merge it to this branch and complete them in same branch (and in this PR). Alternatively, we can merge "add-profile-flag" branch to master, and then start another PR for add-credential-file-flag branch. Also, as I said earlier, we can write more extensive tests for |
|
@kucukaslan could you add |
Previous name of flag was --credential-file and it didn't have any aliases. Also consistently refer to the file as `credentials file`.
|
The tests for macos are canceled with |
|
👍🏻 Thank you |
|
@yermulnik |
|
@igungor Could you please take a look at #553 (comment) + #571 ? Thanks |
6 participants
This commit adds
--profileflag to allow users to specify a named profile rather than using the default.Fixes #353