Merged
Conversation
Collaborator
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Collaborator
|
These commits modify compiler targets. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
oToToT
force-pushed
the
aarch64-v8a
branch
2 times, most recently
from
0462c1c to
c152a73
Compare
After llvm/llvm-project@8689f5e landed, LLVM takes the intersection of v8a and v8r as default. This commit brings back v8a support by explicitly specifying v8a in the feature list. This should solve rust-lang#97724.
Contributor
|
Arm's Rust team agree that this the best course of action due to backwards compatibility and the overwhelming prevalence of A-class processors over R-class ones. We can also expose a new target_feature to support R-class processors which passes |
davidtwco
approved these changes
Dec 2, 2022
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 2, 2022
v8a as default aarch64 target After llvm/llvm-project@8689f5e landed, LLVM takes the intersection of v8a and v8r as default. This commit brings back v8a support by explicitly specifying v8a in the feature list. This should solve rust-lang#97724. p.s. a bit more context can also be found in llvm/llvm-project#57904 (comment).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 2, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#105026 (v8a as default aarch64 target) - rust-lang#105033 (sparc-struct-abi: work around new tail-call optimization) - rust-lang#105144 (Document normalization methods `At::{normalize,query_normalize}`) - rust-lang#105155 (rustdoc: clean up help and settings button CSS) - rust-lang#105162 (Properly synthesize `FnSig` value during cycle) - rust-lang#105163 (Check lifetime param count in `collect_trait_impl_trait_tys`) - rust-lang#105185 (Move `normalize_fn_sig` to `TypeErrCtxt`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Feb 12, 2026
https://blog.rust-lang.org/2026/01/22/Rust-1.93.0/ Rust changes: https://github.com/rust-lang/rust/releases/tag/1.93.0 Cargo changes: https://doc.rust-lang.org/nightly/cargo/CHANGELOG.html#cargo-193-2026-01-22 * rust-oe-selftest.patch updated for 1.93: Renamed UI test directive from add-core-stubs to add-minicore as in rust-lang/rust@3796f7d * OE-selftests: - Exclude src/tools/remote-test-client from test suite. This unit test modifies the TEST_DEVICE_ADDR environment variable, which breaks the OE test harness that uses the same variable for QEMU remote testing. Filed a bug with upstream: rust-lang/rust#151823 - Enable +v8a feature for cortexa57. Rust 1.93.0 added a regression test (PR #149549) to verify that the ARMv8-A system register ttbr0_el2 is recognized in inline assembly. This addresses issue #97724 where LLVM wasn't recognizing ttbr0_el2 as a valid register. Upstream Rust enables +v8a by default for all AArch64 targets (PR #105026), but Yocto's custom target specification doesn't inherit this. Adding +v8a ensures LLVM recognizes ARMv8-A system registers, fixing the test failure. Related upstream links: - PR #149549: rust-lang/rust#149549 - Issue #97724: rust-lang/rust#97724 - PR #105026: rust-lang/rust#105026 Test results: rust v1.93.0 +-------------+--------+---------+ | Machine | Passed | Skipped | +-------------+--------+---------+ | qemux86-64 | 21,689 | 646 | | qemux86 | 21,439 | 896 | | qemuarm64 | 21,495 | 840 | | qemuarm | 21,421 | 914 | | qemuriscv64 | 21,466 | 869 | +-------------+--------+---------+ Test results difference (1.93.0 - 1.92.0): +-------------+--------+---------+ | Machine | Passed | Skipped | +-------------+--------+---------+ | qemux86-64 | +205 | +33 | | qemux86 | +205 | +33 | | qemuarm64 | +206 | +32 | | qemuarm | +205 | +33 | | qemuriscv64 | +205 | +33 | +-------------+--------+---------+ Signed-off-by: Hemanth Kumar M D <Hemanth.KumarMD@windriver.com> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After llvm/llvm-project@8689f5e landed, LLVM takes the intersection of v8a and v8r as default. This commit brings back v8a support by explicitly specifying v8a in the feature list.
This should solve #97724.
p.s. a bit more context can also be found in llvm/llvm-project#57904 (comment).