Check lifetime param count in collect_trait_impl_trait_tys#105163
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 3, 2022
Merged
Check lifetime param count in collect_trait_impl_trait_tys#105163bors merged 1 commit intorust-lang:masterfrom
collect_trait_impl_trait_tys#105163bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
afit-lt-arity
branch
from
1adf6ad to
bd7ee07
Compare
jackh726
reviewed
Dec 2, 2022
| ident: impl_m.ident(tcx), | ||
| generics_span, | ||
| }) | ||
| .emit_unless(delay); |
Member
There was a problem hiding this comment.
This seems a bit weird. Why do we not want to emit an error? The error seems to be getting emitted elsewhere?
jackh726
approved these changes
Dec 2, 2022
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
I guess the delay is in the other functions. Not sure if I like it, but oh well.
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 2, 2022
…ackh726 Check lifetime param count in `collect_trait_impl_trait_tys` We checked the type and const generics count, but not the lifetimes, which were handled in a different function. Fixes rust-lang#105154
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 2, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#105026 (v8a as default aarch64 target) - rust-lang#105033 (sparc-struct-abi: work around new tail-call optimization) - rust-lang#105144 (Document normalization methods `At::{normalize,query_normalize}`) - rust-lang#105155 (rustdoc: clean up help and settings button CSS) - rust-lang#105162 (Properly synthesize `FnSig` value during cycle) - rust-lang#105163 (Check lifetime param count in `collect_trait_impl_trait_tys`) - rust-lang#105185 (Move `normalize_fn_sig` to `TypeErrCtxt`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We checked the type and const generics count, but not the lifetimes, which were handled in a different function.
Fixes #105154