rustdoc: allow popover child links to work

[ardislu]

No need to prevent default click behavior on a <div>, it will also disable all child click behavior.

Closes #106390

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information.

[rustbot]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

[GuillaumeGomez]

Do you want to add the GUI test too (in src/test/rustdoc-gui, there is a README file)? If not I'll add it once this PR is merged.

[ardislu]

Sure, I gave it a shot.

Some notes:

• I'm not familiar with this testing framework, apologies if I put the test in the wrong place.
• I'm hardcoding the URL https://doc.rust-lang.org/rustdoc/ into the test, if this URL changes or redirects to a different one in the future then the test will fail.

[ardislu]

My initial test case was getting this error:

(line 71) Error: Execution context was destroyed, most likely because of a navigation.: for command `assert-document-property: {"URL": "https://doc.rust-lang.org/rustdoc/"}`

I checked some Puppeteer issues and it seems like the proper way to write this test is to use Page.waitForNavigation(), however I'm not sure how to translate this method into the .goml file/testing framework.

I tried to look for some other test cases that navigated to external websites, but I couldn't find any (all other test navigations I could find only tested navigation within the rustdoc website).

Inserting a simple wait-for-document-property didn't work (same error):

wait-for-document-property: {"URL": "https://doc.rust-lang.org/rustdoc/"}

Waiting for generic HTML also didn't work (same error):

wait-for: "html"
wait-for: "body"

As a last resort workaround, I hardcoded a wait time of 2000ms and now it works. However, this is pretty fragile and not the best way to do it. I think this might be a limitation of the testing framework (ability to call Page.waitForNavigation() needs to get added somewhere). Am I missing something? Or maybe there's a better way to test a successful link navigation to an external website?

Appreciate any suggestions. Thank you!

[GuillaumeGomez]

I actually had in mind to use wait-for-document-property. I'm surprised that the context issue is a problem in this case as well... For now let's keep it as is and then come back to it once we have the needed pieces.

Thanks for adding the GUI test in any case!

@bors r+ rollup

[bors]

📌 Commit 9792c9a has been approved by GuillaumeGomez

It is now in the queue for this repository.