Merge borrowck permission checks#106451
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 5, 2023
Merged
Conversation
Merge `check_access_permission` and `check_if_reassignment_to_immutable_state`. The goal of this commit is twofold: First, we simplify the codebase by removing duplicate logic. Second, we avoid duplicate reporting of illegal reassignment errors by reusing the exiting de-duplicating logic of access_place.
Collaborator
|
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 5, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106391 (rustdoc: allow popover child links to work) - rust-lang#106398 (Fix a few clippy lints in libtest) - rust-lang#106412 (Fix link generation for local primitive types in rustdoc JSON output) - rust-lang#106437 (rustdoc: fix buggy JS check for absolute URL) - rust-lang#106451 (Merge borrowck permission checks) - rust-lang#106460 (Move tests) - rust-lang#106461 (docs: fix broken link "search bar") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
check_access_permissionandcheck_if_reassignment_to_immutable_state.The goal of this commit is twofold: