inline format!() args from rustc_middle up to and including rustc_codegen_llvm (3)#114074
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 30, 2023
Merged
inline format!() args from rustc_middle up to and including rustc_codegen_llvm (3)#114074bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino Some changes occurred in need_type_info.rs cc @lcnr |
matthiaskrgr
changed the title
matthiaskrgr
changed the title
Collaborator
|
☔ The latest upstream changes (presumably #114181) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
There was a problem hiding this comment.
Can you revert all changes in this file? I think that's another case of {{ being confusing with inline formatting args
Member
There was a problem hiding this comment.
Suggested change
| debug!(" _{}", sym); | |
| debug!(" _{sym}"); |
Member
There was a problem hiding this comment.
Suggested change
| debug!(" _{}", symbol); | |
| debug!(" _{symbol}"); |
Member
There was a problem hiding this comment.
Suggested change
| debug!(" {};", sym); | |
| debug!(" {sym};"); |
Member
There was a problem hiding this comment.
Suggested change
| debug!(" _{}", symbol); | |
| debug!(" _{symbol}"); |
Member
There was a problem hiding this comment.
Suggested change
| debug!(" _{}", symbol); | |
| debug!(" _{symbol}"); |
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
matthiaskrgr
force-pushed
the
fmt_args_rustc_2
branch
3 times, most recently
from
7360c41 to
a983d17
Compare
matthiaskrgr
force-pushed
the
fmt_args_rustc_2
branch
from
a983d17 to
3ce90b1
Compare
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
WaffleLapkin
approved these changes
Jul 30, 2023
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#98154 (merge functionality of `io::Sink` into `io::Empty`) - rust-lang#102198 (`const`-stablilize `NonNull::as_ref`) - rust-lang#114074 (inline format!() args from rustc_middle up to and including rustc_codegen_llvm (3)) - rust-lang#114246 (Weaken unnameable_types lint) - rust-lang#114256 (Fix invalid suggestion for mismatched types in closure arguments) - rust-lang#114258 (Simplify `Span::can_be_used_for_suggestions` a little tiny bit) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @WaffleLapkin