[rustdoc] [GUI tests] Make theme switching closer to reality#123624
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 9, 2024
Merged
[rustdoc] [GUI tests] Make theme switching closer to reality#123624bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Not sure what's wrong with the CI here. Maybe cache is involved somehow? Gonna ask the infra team. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
theme-switch-tests
branch
from
dfedacb to
9fadad7
Compare
Member
Author
|
Fixed the CI! \o/ |
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#122768 (Use the more informative generic type inference failure error on method calls on raw pointers) - rust-lang#123620 (sanitizers: Create the rustc_sanitizers crate) - rust-lang#123624 ([rustdoc] [GUI tests] Make theme switching closer to reality) - rust-lang#123636 (Update books) - rust-lang#123647 (rustdoc: slightly clean up the synthesis of blanket impls) - rust-lang#123648 (Avoid ICEing without the pattern_types feature gate) - rust-lang#123649 (KCFI: Use legal charset in shim encoding) - rust-lang#123652 (Fix UI tests with dist-vendored dependencies) - rust-lang#123655 (Remove unimplemented!() from BinOp::ty() function) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2024
Rollup merge of rust-lang#123624 - GuillaumeGomez:theme-switch-tests, r=notriddle [rustdoc] [GUI tests] Make theme switching closer to reality Better to actually perform actions user do rather than only testing the change through local storage. As for `browser-ui-test` update: I updated `puppeteer` version (to `0.19.4`) and fixed a bug when displaying the file if it came from an `include`. r? `@notriddle`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better to actually perform actions user do rather than only testing the change through local storage.
As for
browser-ui-testupdate: I updatedpuppeteerversion (to0.19.4) and fixed a bug when displaying the file if it came from aninclude.r? @notriddle