Remove unimplemented!() from BinOp::ty() function#123655
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 9, 2024
Merged
Remove unimplemented!() from BinOp::ty() function#123655bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
To reduce redundancy, we now internalize the BinOp instead of duplicating the `ty()` function body.
celinval
force-pushed
the
smir-fix-binop-ty
branch
from
4b62fc8 to
0a4f4a3
Compare
compiler-errors
approved these changes
Apr 8, 2024
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Yeah, I guess it's much better to avoid reimplementing Binop::ty here.
Contributor
|
r=me after CI is green, unless you want a review specifically from oli |
Contributor
Author
|
@bors r=@compiler-errors rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#122768 (Use the more informative generic type inference failure error on method calls on raw pointers) - rust-lang#123620 (sanitizers: Create the rustc_sanitizers crate) - rust-lang#123624 ([rustdoc] [GUI tests] Make theme switching closer to reality) - rust-lang#123636 (Update books) - rust-lang#123647 (rustdoc: slightly clean up the synthesis of blanket impls) - rust-lang#123648 (Avoid ICEing without the pattern_types feature gate) - rust-lang#123649 (KCFI: Use legal charset in shim encoding) - rust-lang#123652 (Fix UI tests with dist-vendored dependencies) - rust-lang#123655 (Remove unimplemented!() from BinOp::ty() function) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2024
Rollup merge of rust-lang#123655 - celinval:smir-fix-binop-ty, r=compiler-errors Remove unimplemented!() from BinOp::ty() function To reduce redundancy, we now internalize the BinOp instead of duplicating the `ty()` function body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce redundancy, we now internalize the BinOp instead of duplicating the
ty()function body.