Remove `rustdoc` adhoc group#152310

Kobzol · 2026-02-07T21:11:38Z

With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that r? <team> does not consider them if they don't want to.

That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than t-compiler to test this, so I started with rustdoc, which was the smallest team that I found an adhoc group for.

Currently, the rustdoc team contains the following members:

aDotInTheVoid
GuillaumeGomez
notriddle
fmease
camelid
Manishearth
Urgau
lolbinarycat
yotamofek

Only three of those were previously assignable through r? rustdoc. So to reproduce the previous state, I will run as <username> work set-team-rotation-mode rustdoc off for the remaining members of the rustdoc team before this is merged.

If more people from t-rustdoc want to join the review rotation, they can send triagebot a DM with work set-team-rotation-mode rustdoc on.

CC @rust-lang/rustdoc

rustbot · 2026-02-07T21:11:41Z

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

rustbot · 2026-02-07T21:11:43Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Fallback group: @Mark-Simulacrum, @jieyouxu
@Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
Random selection from Mark-Simulacrum, jieyouxu

Urgau · 2026-02-07T21:19:37Z

r? Urgau

Kobzol · 2026-02-07T21:21:17Z

I set everyone except GuillaumeGomez, fmease and notriddle to be off rotation for rustdoc, to reproduce the earlier state. You can check by sending team-stats rustdoc to triagebot on Zulip.

Urgau · 2026-02-07T21:28:22Z

team-stats rustdoc reports as expected GuillaumeGomez, notriddle and fmease as being on-rotation.

The other members are off rotation because of "Team review prefs".

Urgau

Looks good to me. Let's try it.

View changes since this review

Urgau · 2026-02-07T21:28:59Z

@bors r+ rollup

rust-bors · 2026-02-07T21:29:02Z

📌 Commit d53133e has been approved by Urgau

It is now in the queue for this repository.

… r=Urgau Remove `rustdoc` adhoc group With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to. That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for. Currently, the `rustdoc` team contains the following members: - aDotInTheVoid - GuillaumeGomez - notriddle - fmease - camelid - Manishearth - Urgau - lolbinarycat - yotamofek Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged. If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`. CC @rust-lang/rustdoc

Remove `rustdoc` adhoc group With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to. That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for. Currently, the `rustdoc` team contains the following members: - aDotInTheVoid - GuillaumeGomez - notriddle - fmease - camelid - Manishearth - Urgau - lolbinarycat - yotamofek Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged. If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`. CC @rust-lang/rustdoc

rust-bors · 2026-02-08T01:50:23Z

⌛ Testing commit d53133e with merge 90bc0f9...

Zalathar · 2026-02-08T01:54:51Z

@bors yield (to enclosing rollup)

rust-bors · 2026-02-08T01:54:54Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/21790379846

The next pull request likely to be tested is #152314.

Rollup of 2 pull requests Successful merges: - #152310 (Remove `rustdoc` adhoc group) - #152284 (Avoid a bogus THIR span for `let x = offset_of!(..)`)

Rollup merge of #152310 - Kobzol:remove-rustdoc-adhoc-group, r=Urgau Remove `rustdoc` adhoc group With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to. That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for. Currently, the `rustdoc` team contains the following members: - aDotInTheVoid - GuillaumeGomez - notriddle - fmease - camelid - Manishearth - Urgau - lolbinarycat - yotamofek Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged. If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`. CC @rust-lang/rustdoc

…-Simulacrum Remove more adhoc groups that correspond to teams Following in the footsteps of rust-lang#152310. - [types](https://github.com/rust-lang/team/blob/main/teams/types.toml) team - removed Niko and lqd from team rotation in triagebot - [project-const-traits](https://github.com/rust-lang/team/blob/main/teams/project-const-traits.toml) - no changes needed, whole team was already on rotation - [project-stable-mir](https://github.com/rust-lang/team/blob/main/teams/project-stable-mir.toml) - no changes needed, whole team was already on rotation - [project-exploit-mitigations](https://github.com/rust-lang/team/blob/main/teams/project-exploit-mitigations.toml) - removed 1c3t3a from team rotation in triagebot (TODO - it didn't work yet, need to fix triagebot to allow running commands on top of people that are only in project/working groups)

Rollup merge of #152325 - Kobzol:remove-adhoc-groups, r=Mark-Simulacrum Remove more adhoc groups that correspond to teams Following in the footsteps of #152310. - [types](https://github.com/rust-lang/team/blob/main/teams/types.toml) team - removed Niko and lqd from team rotation in triagebot - [project-const-traits](https://github.com/rust-lang/team/blob/main/teams/project-const-traits.toml) - no changes needed, whole team was already on rotation - [project-stable-mir](https://github.com/rust-lang/team/blob/main/teams/project-stable-mir.toml) - no changes needed, whole team was already on rotation - [project-exploit-mitigations](https://github.com/rust-lang/team/blob/main/teams/project-exploit-mitigations.toml) - removed 1c3t3a from team rotation in triagebot (TODO - it didn't work yet, need to fix triagebot to allow running commands on top of people that are only in project/working groups)

Remove rustdoc adhoc group

d53133e

rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026

rustbot assigned jieyouxu Feb 7, 2026

rustbot assigned Urgau and unassigned jieyouxu Feb 7, 2026

Urgau approved these changes Feb 7, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026

JonathanBrouwer mentioned this pull request Feb 7, 2026

Rollup of 2 pull requests #152312

Closed

camelid approved these changes Feb 7, 2026

View reviewed changes

Zalathar mentioned this pull request Feb 8, 2026

Rollup of 2 pull requests #152314

Merged

rust-bors bot merged commit d016a67 into rust-lang:main Feb 8, 2026
11 of 12 checks passed

rustbot added this to the 1.95.0 milestone Feb 8, 2026

Kobzol deleted the remove-rustdoc-adhoc-group branch February 8, 2026 07:16

Kobzol mentioned this pull request Feb 8, 2026

Remove more adhoc groups that correspond to teams #152325

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `rustdoc` adhoc group#152310