Allow users to configure per-team rotation mode#2273
Merged
Kobzol merged 11 commits intorust-lang:masterfrom Feb 7, 2026
Merged
Allow users to configure per-team rotation mode#2273Kobzol merged 11 commits intorust-lang:masterfrom
Kobzol merged 11 commits intorust-lang:masterfrom
Conversation
Member
Author
|
Rebased. |
Urgau
reviewed
Feb 7, 2026
Member
Author
|
Also refactored |
Urgau
approved these changes
Feb 7, 2026
This was referenced Feb 7, 2026
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 7, 2026
… r=Urgau Remove `rustdoc` adhoc group With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to. That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for. Currently, the `rustdoc` team contains the following members: - aDotInTheVoid - GuillaumeGomez - notriddle - fmease - camelid - Manishearth - Urgau - lolbinarycat - yotamofek Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged. If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`. CC @rust-lang/rustdoc
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Feb 8, 2026
Remove `rustdoc` adhoc group With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to. That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for. Currently, the `rustdoc` team contains the following members: - aDotInTheVoid - GuillaumeGomez - notriddle - fmease - camelid - Manishearth - Urgau - lolbinarycat - yotamofek Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged. If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`. CC @rust-lang/rustdoc
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 8, 2026
… r=Urgau Remove `rustdoc` adhoc group With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to. That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for. Currently, the `rustdoc` team contains the following members: - aDotInTheVoid - GuillaumeGomez - notriddle - fmease - camelid - Manishearth - Urgau - lolbinarycat - yotamofek Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged. If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`. CC @rust-lang/rustdoc
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 8, 2026
Rollup merge of #152310 - Kobzol:remove-rustdoc-adhoc-group, r=Urgau Remove `rustdoc` adhoc group With rust-lang/triagebot#2273, reviewers can now tell triagebot to opt them out of being assigned through a given team, so that `r? <team>` does not consider them if they don't want to. That means that we can now finally get rid of adhoc groups that correspond to actual Rust teams. I wanted to start with a smaller team than `t-compiler` to test this, so I started with `rustdoc`, which was the smallest team that I found an adhoc group for. Currently, the `rustdoc` team contains the following members: - aDotInTheVoid - GuillaumeGomez - notriddle - fmease - camelid - Manishearth - Urgau - lolbinarycat - yotamofek Only three of those were previously assignable through `r? rustdoc`. So to reproduce the previous state, I will run `as <username> work set-team-rotation-mode rustdoc off` for the remaining members of the `rustdoc` team before this is merged. If more people from `t-rustdoc` want to join the review rotation, they can send [triagebot](https://rust-lang.zulipchat.com/#narrow/dm/261224-triagebot) a DM with `work set-team-rotation-mode rustdoc on`. CC @rust-lang/rustdoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed in https://rust-lang.zulipchat.com/#narrow/channel/224082-triagebot/topic/Extending.20review.20queue.20tracking/with/572421150.
Each reviewer can now set if they want to be assignable through a team. For example, if someone is a member of
t-compilerand someone writesr? compiler, you can set if you want to be in the set of people who will be possibly assigned to such a PR, withwork set-team-rotation-mode compiler off/on.This is taken into account when computing assignments. The previous user preferences are still valid, and have higher priority in a way, so
set-rotation-mode offwill remove you from all rotations.Best reviewed commit-by-commit.