std::ops::ControlFlow - use normal comment for internal methods#152877
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 20, 2026
Merged
std::ops::ControlFlow - use normal comment for internal methods#152877rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Rather than a doc comment, which causes rustdoc to output the impl documentation even though the impl block only has non-public methods.
rustbot
added
S-waiting-on-review
Collaborator
|
Failed to set assignee to
|
Contributor
Author
|
@rustbot reroll |
Collaborator
|
Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''... Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
eggyal
approved these changes
Feb 20, 2026
Member
|
Oh yeah, https://doc.rust-lang.org/nightly/std/ops/enum.ControlFlow.html#impl-ControlFlow%3CR,+%3CR+as+Try%3E::Output%3E does look pretty bad, doesn't it. @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152759 (Simpler `find_attr!()`) - #152057 (bootstrap: respect POSIX jobserver) - #152818 (DOC: do not link to "nightly" in Iterator::by_ref() docstring) - #152840 (Add bootstrap snapshot tests for {`install`, `install src`}) - #152844 (Rename `DepGraphQuery` to `RetainedDepGraph`) - #152846 (Clarify some variable names in the query proc-macro) - #152858 (Fix typo in doc for core::mem::type_info::Struct) - #152861 (resolve: do not suggest `_` for unresolved imports) - #152873 (std::ops::ControlFlow - use "a" before `Result`) - #152877 (std::ops::ControlFlow - use normal comment for internal methods) - #152883 (Deny final not followed by item)
rust-timer
added a commit
that referenced
this pull request
Feb 20, 2026
Rollup merge of #152877 - DanielEScherzer:patch-3, r=scottmcm std::ops::ControlFlow - use normal comment for internal methods Rather than a doc comment, which causes rustdoc to output the impl documentation even though the impl block only has non-public methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than a doc comment, which causes rustdoc to output the impl documentation even though the impl block only has non-public methods.