Skip to content

Comments

Deny final not followed by item#152883

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
mu001999-contrib:fix/final-bad-use
Feb 20, 2026
Merged

Deny final not followed by item#152883
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
mu001999-contrib:fix/final-bad-use

Conversation

@mu001999
Copy link
Contributor

@mu001999 mu001999 commented Feb 20, 2026

Fixes #152820

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 20, 2026
@mu001999 mu001999 marked this pull request as ready for review February 20, 2026 04:13
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 14 candidates

@Kivooeo
Copy link
Member

Kivooeo commented Feb 20, 2026

r? me

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit 5978115 has been approved by Kivooeo

It is now in the queue for this repository.

@rustbot rustbot assigned Kivooeo and unassigned petrochenkov Feb 20, 2026
@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 20, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152759 (Simpler `find_attr!()`)
 - #152057 (bootstrap: respect POSIX jobserver)
 - #152818 (DOC: do not link to "nightly" in Iterator::by_ref() docstring)
 - #152840 (Add bootstrap snapshot tests for {`install`, `install src`})
 - #152844 (Rename `DepGraphQuery` to `RetainedDepGraph`)
 - #152846 (Clarify some variable names in the query proc-macro)
 - #152858 (Fix typo in doc for core::mem::type_info::Struct)
 - #152861 (resolve: do not suggest `_` for unresolved imports)
 - #152873 (std::ops::ControlFlow - use "a" before `Result`)
 - #152877 (std::ops::ControlFlow - use normal comment for internal methods)
 - #152883 (Deny final not followed by item)
@rust-bors rust-bors bot merged commit a196a00 into rust-lang:main Feb 20, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 20, 2026
Rollup merge of #152883 - mu001999-contrib:fix/final-bad-use, r=Kivooeo

Deny final not followed by item

Fixes #152820
@rustbot rustbot added this to the 1.95.0 milestone Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Under FAF we now wrongly accept final $($expr)? in stmt position parsing it as $($expr)?

4 participants