add emit_debug_gdb_scripts target option and ..#49728
Merged
bors merged 2 commits intorust-lang:masterfrom Apr 7, 2018
Merged
Conversation
set it to false for no-std targets like ARM Cortex-M and MSP430. For the rationale of this change see the comment in thumb_base.rs
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors: r+ Nice! |
Collaborator
|
📌 Commit 1eed662 has been approved by |
bors
added
S-waiting-on-bors
japaric
added a commit
to rust-embedded/cortex-m-rt
that referenced
this pull request
Apr 6, 2018
this commit adds LLD support by removing all INFO sections. LLD kind of supports INFO in the form of NOLOAD but when the linker script contains NOLOAD sections LLD emits a binary with false `size` information: for example, it reported a fake increase of 20KB in .text and a fake increase of 1KB in .bss when compiling a program that only allocates a single Box. As the INFO sections are gone we can no longer support the stack overflow protection added in #43 so all the other related changes, like making _stack_start overridable, have been removed as well. If you want to continue using stack overflow protection you can stick to v0.3.x. As the .debug_gdb_scripts output section has been removed from the linker script these changes will only reliably support both LD and LLD if/when rust-lang/rust#49728 lands. closes #53
Contributor
Author
|
I forgot to cc @pftbest and @whitequark |
whitequark
reviewed
Apr 6, 2018
Contributor
whitequark
left a comment
whitequark
left a comment
There was a problem hiding this comment.
Seems reasonable to me other than the macOS change.
| exe_allocation_crate: super::maybe_jemalloc(), | ||
| has_elf_tls: version >= (10, 7), | ||
| abi_return_struct_as_int: true, | ||
| emit_debug_gdb_scripts: false, |
Contributor
There was a problem hiding this comment.
Is this really right? Does no one use gdb on macOS?
Contributor
Author
There was a problem hiding this comment.
This doesn't directly answer your question but this is equivalent to the current logic. See the diff on src/librustc_trans/debuginfo/gdb.rs; it has !cx.sess().target.target.options.is_like_osx. So I assume the answer is that people mainly use lldb?
Contributor
There was a problem hiding this comment.
@whitequark Locally gdb is a pain to use on macOS because it would need to be signed in order to have access to process information and no-one cares to actually sign it and it's not shipped with macOS. It is "usable" for target != host but not necessarily the best option.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 7, 2018
…xcrichton add emit_debug_gdb_scripts target option and .. set it to false for no-std targets like ARM Cortex-M and MSP430. For the rationale of this change see the comment in thumb_base.rs this is a temporary workaround until rust-lang#44993 is implemented r? @alexcrichton or @michaelwoerister
bors
added a commit
that referenced
this pull request
Apr 7, 2018
Rollup of 9 pull requests Successful merges: - #49510 (Fix anchor position on fields) - #49652 (Fix anchors issue when everything is collapsed) - #49702 (std: Inline some Termination-related methods) - #49728 (add emit_debug_gdb_scripts target option and ..) - #49731 (add THUMB targets to rustup manifest) - #49742 (Using X headings instead of 0.X #49739) - #49748 (proc_macro: Improve Debug representations) - #49750 (bootstrap: Remove the fast path) - #49503 (Inject the `compiler_builtins` crate whenever the `core` crate is injected) Failed merges:
japaric
added a commit
to rust-embedded/cortex-m-rt
that referenced
this pull request
Apr 8, 2018
this commit adds LLD support by removing all INFO sections. LLD kind of supports INFO in the form of NOLOAD but when the linker script contains NOLOAD sections LLD emits a binary with false `size` information: for example, it reported a fake increase of 20KB in .text and a fake increase of 1KB in .bss when compiling a program that only allocates a single Box. As the INFO sections are gone we can no longer support the stack overflow protection added in #43 so all the other related changes, like making _stack_start overridable, have been removed as well. If you want to continue using stack overflow protection you can stick to v0.3.x. As the .debug_gdb_scripts output section has been removed from the linker script these changes will only reliably support both LD and LLD if/when rust-lang/rust#49728 lands. closes #53
kennytm
pushed a commit
to kennytm/rust
that referenced
this pull request
Aug 7, 2018
Same as the other embedded targets, see: rust-lang#49728 This is a temporary workaround for rust-lang#44993.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 7, 2018
…ochenkov set emit_debug_gdb_scripts: false for riscv32imac-unknown-none target Same as the other embedded targets, see: rust-lang#49728 This is a temporary workaround for rust-lang#44993.
adamgreig
pushed a commit
to rust-embedded/cortex-m
that referenced
this pull request
Jan 12, 2022
this commit adds LLD support by removing all INFO sections. LLD kind of supports INFO in the form of NOLOAD but when the linker script contains NOLOAD sections LLD emits a binary with false `size` information: for example, it reported a fake increase of 20KB in .text and a fake increase of 1KB in .bss when compiling a program that only allocates a single Box. As the INFO sections are gone we can no longer support the stack overflow protection added in #43 so all the other related changes, like making _stack_start overridable, have been removed as well. If you want to continue using stack overflow protection you can stick to v0.3.x. As the .debug_gdb_scripts output section has been removed from the linker script these changes will only reliably support both LD and LLD if/when rust-lang/rust#49728 lands. closes #53
reitermarkus
pushed a commit
to reitermarkus/cortex-m
that referenced
this pull request
May 4, 2022
this commit adds LLD support by removing all INFO sections. LLD kind of supports INFO in the form of NOLOAD but when the linker script contains NOLOAD sections LLD emits a binary with false `size` information: for example, it reported a fake increase of 20KB in .text and a fake increase of 1KB in .bss when compiling a program that only allocates a single Box. As the INFO sections are gone we can no longer support the stack overflow protection added in rust-embedded#43 so all the other related changes, like making _stack_start overridable, have been removed as well. If you want to continue using stack overflow protection you can stick to v0.3.x. As the .debug_gdb_scripts output section has been removed from the linker script these changes will only reliably support both LD and LLD if/when rust-lang/rust#49728 lands. closes rust-embedded#53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set it to false for no-std targets like ARM Cortex-M and MSP430. For the rationale of this change see the comment in thumb_base.rs
this is a temporary workaround until #44993 is implemented
r? @alexcrichton or @michaelwoerister