Merged
Conversation
MMory
approved these changes
Feb 29, 2024
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
lgtm, thanks! We should port these fixes to the fieldsens branch, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
joinImplin theIDEInstInteractionAnalysisdoes not correctly model a join-lattice for the edge valuesl_t.This PR fixes this issue and also fixes the subsequent errors that showed up after the joinImpl-fix.
Concretely, the edge-functions have been changed that were created when generating a fact from zero. In this case, the attached edge-value should not depend on the value attached to zero.
Furthermore, the kill-or-replace edge function has been identified as "constant" and adapted accordingly.
#699 Should be merged first.