Update setup-dotnet to v4.2.0 and clear old endpoints#3527
Merged
imnasnainaec merged 2 commits intomasterfrom Jan 17, 2025
Merged
Update setup-dotnet to v4.2.0 and clear old endpoints#3527imnasnainaec merged 2 commits intomasterfrom
imnasnainaec merged 2 commits intomasterfrom
Conversation
was v4.0.1 to v4.2.0
imnasnainaec
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
=======================================
Coverage 74.55% 74.55%
=======================================
Files 286 286
Lines 11022 11022
Branches 1344 1344
=======================================
Hits 8217 8217
Misses 2418 2418
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hahn-kev
reviewed
Jan 17, 2025
Contributor
hahn-kev
left a comment
hahn-kev
left a comment
There was a problem hiding this comment.
looks good to me, it does look like ci.dot.net was added but I suspect that would only be used if we were to try and use a nightly build in setup-dotnet so it's probably not worth adding
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3524
This change is