Skip to content

Clean up login/token/user-related things#3938

Merged
imnasnainaec merged 5 commits intomasterfrom
user-utils
Aug 20, 2025
Merged

Clean up login/token/user-related things#3938
imnasnainaec merged 5 commits intomasterfrom
user-utils

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 19, 2025

Sequel to #3920

Prequel to #3877

Changes:

  • InviteController: method ValidateToken -> ValidateInviteToken (to avoid ambiguity in OpenAPI with other tokens)
  • PasswordResetService:
    • param EmailOrUsername -> emailOrUsername
    • remove unnecessary method ExpirePasswordReset
    • email title "Combine ..." -> "The Combine ..."
  • InvalidLink component: add prop for optional body text
  • ProjectInvite component: remove extraneous executions of validateLink
  • SignUp component: prop returnToEmailInvite -> onSignup (for more general use)
  • UserSettings component: set email state from normalization of new emailPunycode state (to only normalize in one place)
  • userUtilities:
    • created from two utilities functions and one UserSettings function
    • enqueueSnackbar -> toast.success

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.76%. Comparing base (3078992) to head (100ef0f).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/components/InvalidLink/index.tsx 0.00% 5 Missing ⚠️
src/components/Login/ProjectInvite.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3938      +/-   ##
==========================================
- Coverage   73.78%   73.76%   -0.02%     
==========================================
  Files         289      290       +1     
  Lines       10565    10563       -2     
  Branches     1328     1328              
==========================================
- Hits         7795     7792       -3     
- Misses       2386     2387       +1     
  Partials      384      384              
Flag Coverage Δ
backend 85.40% <100.00%> (-0.01%) ⬇️
frontend 65.06% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 21 of 21 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 20, 2025 18:12
@imnasnainaec imnasnainaec merged commit 6b1646b into master Aug 20, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the user-utils branch August 20, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants