Clean up login/token/user-related things#3938
Merged
imnasnainaec merged 5 commits intomasterfrom Aug 20, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3938 +/- ##
==========================================
- Coverage 73.78% 73.76% -0.02%
==========================================
Files 289 290 +1
Lines 10565 10563 -2
Branches 1328 1328
==========================================
- Hits 7795 7792 -3
- Misses 2386 2387 +1
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
approved these changes
Aug 20, 2025
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 21 of 21 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to #3920
Prequel to #3877
Changes:
InviteController: methodValidateToken->ValidateInviteToken(to avoid ambiguity in OpenAPI with other tokens)PasswordResetService:EmailOrUsername->emailOrUsernameExpirePasswordResetInvalidLinkcomponent: add prop for optional body textProjectInvitecomponent: remove extraneous executions ofvalidateLinkSignUpcomponent: propreturnToEmailInvite->onSignup(for more general use)UserSettingscomponent: setemailstate from normalization of newemailPunycodestate (to only normalize in one place)userUtilities:utilitiesfunctions and oneUserSettingsfunctionenqueueSnackbar->toast.successThis change is