This repository was archived by the owner on Sep 30, 2024. It is now read-only.
bext: ignore non-code diff content hovers on Bitbucket#52609
Merged
taras-yemets merged 4 commits intomainfrom May 30, 2023
Merged
Conversation
umpox
approved these changes
May 30, 2023
sashaostrikov
approved these changes
May 30, 2023
Contributor
sashaostrikov
left a comment
sashaostrikov
left a comment
There was a problem hiding this comment.
LGTM! Added a comment to fix a typo
Contributor
taras-yemets
deleted the
taras-yemets/bext-do-not-trigger-code-intel-requests-for-non-code-content-on-bitbucket
branch
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2023
(cherry picked from commit 7061ff7)
coury-clark
pushed a commit
that referenced
this pull request
May 30, 2023
…#52613) Closes https://github.com/sourcegraph/sourcegraph/issues/52610 Ignore hovers over Bitbucket's additional (non-code) diff line content (comments, etc.). Before (native integration): https://www.loom.com/share/42b603199b394be7984f661e5722c449 After (browser extension): https://github.com/sourcegraph/sourcegraph/assets/25318659/fae4e9d4-7c4d-4a38-9ced-43ab66089efe ## Test plan Tested manually. Demo attached. <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport 7061ff7 from #52609 Co-authored-by: Taras Yemets <yemets.taras@gmail.com>
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/52610
Ignore hovers over Bitbucket's additional (non-code) diff line content (comments, etc.).
Before (native integration): https://www.loom.com/share/42b603199b394be7984f661e5722c449
After (browser extension):
Screen.Recording.2023-05-30.at.15.55.38.mov
Test plan
Tested manually. Demo attached.