This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.0] bext: ignore non-code diff content hovers on Bitbucket#52613
Merged
coury-clark merged 1 commit into5.0from May 30, 2023
Merged
[Backport 5.0] bext: ignore non-code diff content hovers on Bitbucket#52613coury-clark merged 1 commit into5.0from
coury-clark merged 1 commit into5.0from
Conversation
(cherry picked from commit 7061ff7)
taras-yemets
approved these changes
May 30, 2023
Comment on lines
+18
to
+22
| ## Chrome & Firefox 23.4.14.1343, Safari 1.24 | ||
|
|
||
| - Fix view on Sourcegraph links on GitHub (global navigation update feature enabled): https://github.com/sourcegraph/sourcegraph/pull/50551 | ||
| - Bump code-intel extensions bundles version: https://github.com/sourcegraph/sourcegraph/pull/50631 | ||
|
|
Contributor
There was a problem hiding this comment.
@keegancsmith, these lines were not part of the original PR. Is it OK that we keep them in the backport PR? It's the changelog update only.
Member
There was a problem hiding this comment.
yeah the automation did this on one of my PRs now as well. I'm not sure why git cherry-pick is deciding to include these. I think it is fine, I will double check when I cut the patch what exactly should and shouldn't be in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/sourcegraph/sourcegraph/issues/52610
Ignore hovers over Bitbucket's additional (non-code) diff line content (comments, etc.).
Before (native integration): https://www.loom.com/share/42b603199b394be7984f661e5722c449
After (browser extension):
Screen.Recording.2023-05-30.at.15.55.38.mov
Test plan
Tested manually. Demo attached.
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Backport 7061ff7 from #52609