This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Always use Commits in HasCommitAfter#62519
Merged
Conversation
This was referenced May 8, 2024
Member
Author
camdencheek
reviewed
May 8, 2024
camdencheek
approved these changes
May 8, 2024
ggilmore
approved these changes
May 8, 2024
836e6b2 to
c578d4c
Compare
cde2256 to
8ec8fdf
Compare
c578d4c to
64cf62c
Compare
8ec8fdf to
c0e2968
Compare
64cf62c to
e45f971
Compare
c0e2968 to
985143d
Compare
e45f971 to
daa97f4
Compare
985143d to
54e601c
Compare
This was referenced May 10, 2024
daa97f4 to
b64a0f7
Compare
54e601c to
6750cef
Compare
b64a0f7 to
103f5e3
Compare
6750cef to
a4c639d
Compare
103f5e3 to
6af60b8
Compare
Base automatically changed from
es/05-08-gitserverimplementcommitlogusingcommits
to
main
May 10, 2024 23:21
There used to be two implementations of this, one for with subrepo enabled, one for without. This PR aligns those two to both use the Commits method. One code path less, and one API less that we need to port to gRPC. Test plan: Existing unit tests are still passing.
a4c639d to
36c1679
Compare
Member
Author
This was referenced May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

There used to be two implementations of this, one for with subrepo enabled, one for without. This PR aligns those two to both use the Commits method.
One code path less, and one API less that we need to port to gRPC.
Test plan:
Existing unit tests are still passing.