Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: Always use Commits in HasCommitAfter#62519

Merged
eseliger merged 1 commit intomainfrom
es/gitserver-hascommitafter
May 10, 2024
Merged

gitserver: Always use Commits in HasCommitAfter#62519
eseliger merged 1 commit intomainfrom
es/gitserver-hascommitafter

Conversation

@eseliger
Copy link
Member

@eseliger eseliger commented May 8, 2024

There used to be two implementations of this, one for with subrepo enabled, one for without. This PR aligns those two to both use the Commits method.
One code path less, and one API less that we need to port to gRPC.

Test plan:

Existing unit tests are still passing.

@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 8, 2024
@eseliger eseliger marked this pull request as ready for review May 8, 2024 17:15
@eseliger eseliger requested review from a team and camdencheek May 8, 2024 17:15
@eseliger eseliger force-pushed the es/05-08-gitserverimplementcommitlogusingcommits branch from 836e6b2 to c578d4c Compare May 10, 2024 18:39
@eseliger eseliger force-pushed the es/gitserver-hascommitafter branch from cde2256 to 8ec8fdf Compare May 10, 2024 18:39
@eseliger eseliger force-pushed the es/05-08-gitserverimplementcommitlogusingcommits branch from c578d4c to 64cf62c Compare May 10, 2024 19:27
@eseliger eseliger force-pushed the es/gitserver-hascommitafter branch from 8ec8fdf to c0e2968 Compare May 10, 2024 19:27
@eseliger eseliger force-pushed the es/05-08-gitserverimplementcommitlogusingcommits branch from 64cf62c to e45f971 Compare May 10, 2024 19:29
@eseliger eseliger force-pushed the es/gitserver-hascommitafter branch from c0e2968 to 985143d Compare May 10, 2024 19:29
@eseliger eseliger force-pushed the es/05-08-gitserverimplementcommitlogusingcommits branch from e45f971 to daa97f4 Compare May 10, 2024 20:16
@eseliger eseliger force-pushed the es/gitserver-hascommitafter branch from 985143d to 54e601c Compare May 10, 2024 20:16
@eseliger eseliger force-pushed the es/05-08-gitserverimplementcommitlogusingcommits branch from daa97f4 to b64a0f7 Compare May 10, 2024 22:25
@eseliger eseliger force-pushed the es/gitserver-hascommitafter branch from 54e601c to 6750cef Compare May 10, 2024 22:25
@eseliger eseliger force-pushed the es/05-08-gitserverimplementcommitlogusingcommits branch from b64a0f7 to 103f5e3 Compare May 10, 2024 22:30
@eseliger eseliger force-pushed the es/gitserver-hascommitafter branch from 6750cef to a4c639d Compare May 10, 2024 22:30
@eseliger eseliger force-pushed the es/05-08-gitserverimplementcommitlogusingcommits branch from 103f5e3 to 6af60b8 Compare May 10, 2024 23:16
Base automatically changed from es/05-08-gitserverimplementcommitlogusingcommits to main May 10, 2024 23:21
There used to be two implementations of this, one for with subrepo enabled, one for without. This PR aligns those two to both use the Commits method.
One code path less, and one API less that we need to port to gRPC.

Test plan:

Existing unit tests are still passing.
@eseliger eseliger force-pushed the es/gitserver-hascommitafter branch from a4c639d to 36c1679 Compare May 10, 2024 23:24
Copy link
Member Author

eseliger commented May 10, 2024

Merge activity

  • May 10, 7:24 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 10, 7:29 PM EDT: @eseliger merged this pull request with Graphite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants