Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: Remove and deprecate no_timeout option from exec#62743

Merged
eseliger merged 1 commit intomainfrom
es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec
May 21, 2024
Merged

gitserver: Remove and deprecate no_timeout option from exec#62743
eseliger merged 1 commit intomainfrom
es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec

Conversation

@eseliger
Copy link
Member

Commands without any timeout are risky, and we just removed the last user of it, so we drop it now.

Test plan:

Removed an unused flag, tests are still passing.

@cla-bot cla-bot bot added the cla-signed label May 16, 2024
@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 16, 2024
@eseliger eseliger marked this pull request as ready for review May 16, 2024 18:59
@eseliger eseliger requested a review from a team May 16, 2024 19:00
@eseliger eseliger force-pushed the es/05-16-rockskipreplacesecondlong-runningprocesswithgrpcapi branch from 2cbe72e to b245a5b Compare May 17, 2024 20:46
@eseliger eseliger force-pushed the es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec branch from b06d031 to 1bf2da1 Compare May 17, 2024 20:46
@eseliger eseliger force-pushed the es/05-16-rockskipreplacesecondlong-runningprocesswithgrpcapi branch from b245a5b to db73857 Compare May 17, 2024 20:48
@eseliger eseliger force-pushed the es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec branch from 1bf2da1 to c380fec Compare May 17, 2024 20:48
@eseliger eseliger force-pushed the es/05-16-rockskipreplacesecondlong-runningprocesswithgrpcapi branch 2 times, most recently from 3574efb to 4dda696 Compare May 21, 2024 15:14
@eseliger eseliger force-pushed the es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec branch from c380fec to b29690c Compare May 21, 2024 15:15
Base automatically changed from es/05-16-rockskipreplacesecondlong-runningprocesswithgrpcapi to main May 21, 2024 15:45
Commands without any timeout are risky, and we just removed the last user of it, so we drop it now.

Test plan:

Removed an unused flag, tests are still passing.
@eseliger eseliger force-pushed the es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec branch from b29690c to ec0803e Compare May 21, 2024 15:56
Copy link
Member Author

eseliger commented May 21, 2024

Merge activity

  • May 21, 11:56 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 21, 12:05 PM EDT: @eseliger merged this pull request with Graphite.

@eseliger eseliger merged commit 3a81173 into main May 21, 2024
@eseliger eseliger deleted the es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec branch May 21, 2024 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants