This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: init licenses tables#63454
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
bobheadxi
force-pushed
the
06-24-feat_enterpriseportal_init_licenses_tables
branch
from
be60edd to
7500584
Compare
bobheadxi
force-pushed
the
ep-subscriptions-tables
branch
from
fdf7443 to
320b550
Compare
bobheadxi
force-pushed
the
06-24-feat_enterpriseportal_init_licenses_tables
branch
2 times, most recently
from
cf9a343 to
a5b3ff4
Compare
unknwon
approved these changes
Jun 25, 2024
bobheadxi
force-pushed
the
ep-subscriptions-tables
branch
from
320b550 to
32bf1b3
Compare
bobheadxi
force-pushed
the
06-24-feat_enterpriseportal_init_licenses_tables
branch
2 times, most recently
from
96f9cb0 to
e7104ed
Compare
bobheadxi
force-pushed
the
ep-subscriptions-tables
branch
from
c0c3741 to
8a5ca69
Compare
bobheadxi
force-pushed
the
06-24-feat_enterpriseportal_init_licenses_tables
branch
2 times, most recently
from
fab2841 to
f152225
Compare
bobheadxi
force-pushed
the
06-24-feat_enterpriseportal_init_licenses_tables
branch
from
f152225 to
f50613d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/CORE-157
Potentially controversial decision: storing license data (the JSON data encoded into license keys, and the license key itself) in JSONB. The data in there isn't (and shouldn't be) interesting to query on - they're only used in the context of a single license, so you would never use it as conditions. The only one that might be useful is "license key substring" for parity with what we have today, but that's an internal-only use case and shouldn't be in the hotpath for anything super performance sensitive.
Conditions table is similar to the one introduced in https://github.com/sourcegraph/sourcegraph/pull/63453
Test plan
CI