Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/enterpriseportal: init Cody Gateway Access table#63457

Merged
bobheadxi merged 2 commits intomainfrom
06-24-feat_enterpriseportal_init_cody_gateway_access_table
Jul 3, 2024
Merged

feat/enterpriseportal: init Cody Gateway Access table#63457
bobheadxi merged 2 commits intomainfrom
06-24-feat_enterpriseportal_init_cody_gateway_access_table

Conversation

@bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Jun 24, 2024

Closes https://linear.app/sourcegraph/issue/CORE-159

I opted to prefix this table name with codyaccess instead of enterprise_portal, to reflect that it's a different component that owns this table.

Test plan

CI

Copy link
Member Author

bobheadxi commented Jun 24, 2024

@bobheadxi bobheadxi marked this pull request as ready for review June 24, 2024 23:05
@bobheadxi bobheadxi requested review from a team and unknwon June 24, 2024 23:06
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from be60edd to 7500584 Compare June 24, 2024 23:10
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from 069f310 to f53d6cf Compare June 24, 2024 23:10
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from 7500584 to cf9a343 Compare June 25, 2024 00:40
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from f53d6cf to d2d24bd Compare June 25, 2024 00:40
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from cf9a343 to a5b3ff4 Compare June 25, 2024 00:44
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from d2d24bd to a2200d5 Compare June 25, 2024 00:44
@unknwon
Copy link
Contributor

unknwon commented Jun 25, 2024

I opted to prefix this table name with codyaccess instead of enterprise_portal

TBH it feels kinda weird haha, the reason we have enterprise_portal only because to avoid conflict in local dev that most services share the same DB. I would say let's stick with enterprise_portal, that's also better grouping. You can still do enterprise_portal_cody_access_xxx

Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the table name

@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from a5b3ff4 to 96f9cb0 Compare June 25, 2024 19:24
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from ecd707e to bdda060 Compare June 25, 2024 19:24
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from 96f9cb0 to e7104ed Compare June 25, 2024 20:01
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from bdda060 to 9f9706b Compare June 25, 2024 20:01
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from e7104ed to fab2841 Compare June 26, 2024 21:32
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from 9f9706b to 3d1d44e Compare June 26, 2024 21:32
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from fab2841 to f152225 Compare June 26, 2024 23:52
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from 3d1d44e to cddff3f Compare June 26, 2024 23:52
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_licenses_tables branch from f152225 to f50613d Compare June 27, 2024 00:13
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch 2 times, most recently from 53a4892 to 0ddffd8 Compare June 27, 2024 16:10
Base automatically changed from 06-24-feat_enterpriseportal_init_licenses_tables to main June 27, 2024 19:53
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from 0ddffd8 to c0def0f Compare June 28, 2024 17:42
@bobheadxi bobheadxi force-pushed the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch from c0def0f to 3a0d64d Compare June 28, 2024 19:08
@bobheadxi bobheadxi merged commit 111621f into main Jul 3, 2024
@bobheadxi bobheadxi deleted the 06-24-feat_enterpriseportal_init_cody_gateway_access_table branch July 3, 2024 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants