Conversation
chore: fix merge conflicts for #1555 Co-authored-by: Juan Medina <jfml_97@live.com>
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2164 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2334 2323 -11
Branches 586 586
=========================================
- Hits 2334 2323 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
chore: clean up PR #1895 --------- Co-authored-by: szabolcstarnai <tarnai.szabolcs01@gmail.com>
Co-authored-by: Alvaro Castro <moltar89@gmail.com> @profnandaa: clean up #2103
fix(isEmail): fixed `isFQDN` still checking email length when `ignore_max_length` is `true` profnandaa: clean-up #2128 --------- Co-authored-by: Said Akhmedbayev <said.akh@gmail.com> Co-authored-by: Said Akhmedbayev <said.akhmedbayev@accenture.com>
profnandaa
force-pushed
the
mcfix/combined-prs
branch
from
e6e78de to
b489355
Compare
src/lib/isPassportNumber.js
Outdated
| MY: /^[AHK]\d{8}$/, // MALAYSIA | ||
| MX: /^\d{10,11}$/, // MEXICO | ||
| NL: /^[A-Z]{2}[A-Z0-9]{6}\d$/, // NETHERLANDS | ||
| NZ: /^([Ll]([Aa]|[Dd]|[Ff]|[Hh])|[Ee]([Aa]|[Pp])|[Nn])\d{6}$/, // NEW ZELAND |
There was a problem hiding this comment.
| NZ: /^([Ll]([Aa]|[Dd]|[Ff]|[Hh])|[Ee]([Aa]|[Pp])|[Nn])\d{6}$/, // NEW ZELAND | |
| NZ: /^([Ll]([Aa]|[Dd]|[Ff]|[Hh])|[Ee]([Aa]|[Pp])|[Nn])\d{6}$/, // NEW ZEALAND |
There was a problem hiding this comment.
good catch, fixed, thanks!
| 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/, | ||
| 'fr-BF': /^(\+226|0)[67]\d{7}$/, | ||
| 'fr-BJ': /^(\+229)\d{8}$/, | ||
| 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/, |
There was a problem hiding this comment.
| 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/, | |
| 'fr-CD': /^(\+?243|0)?(8[0-2489]|9[017-9])\d{7}$/, |
According to https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000370001PDFE.pdf with the addition of Africell phone numbers from https://github.com/google/libphonenumber/blob/master/resources/metadata/243/ranges.csv in line with the comment of the creator of the original PR
There was a problem hiding this comment.
We can fix this in a later PR as well
| 'pt-BR': /^((\+?55\ ?[1-9]{2}\ ?)|(\+?55\ ?\([1-9]{2}\)\ ?)|(0[1-9]{2}\ ?)|(\([1-9]{2}\)\ ?)|([1-9]{2}\ ?))((\d{4}\-?\d{4})|(9[1-9]{1}\d{3}\-?\d{4}))$/, | ||
| 'pt-PT': /^(\+?351)?9[1236]\d{7}$/, | ||
| 'pt-AO': /^(\+244)\d{9}$/, | ||
| 'ro-MD': /^(\+?373|0)((6(0|1|2|6|7|8|9))|(7(6|7|8|9)))\d{6}$/, |
There was a problem hiding this comment.
| 'ro-MD': /^(\+?373|0)((6(0|1|2|6|7|8|9))|(7(6|7|8|9)))\d{6}$/, | |
| 'ro-MD': /^(\+?373|0)((6([089]\d{6}|(1[01]|2[01]|7[1-7])\d{5}))|(7((6[07]|8[0-8])\d{5}|9\d{6})))$/ |
According to https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200008C0003PDFE.pdf
The result is correct but maybe we RegExp might be simplified a bit so I'm open for suggestions on that
There was a problem hiding this comment.
We can fix this in a later PR as well
There was a problem hiding this comment.
I totally agree... we can do a subsequent fix for that.
* maintentance: clean up, closes #2073 --------- Co-authored-by: Digambar <digambartu@gmail.com>
profnandaa
force-pushed
the
mcfix/combined-prs
branch
from
b454080 to
31a74d5
Compare
* maintenance: clean up #2061 --------- Co-authored-by: djeks922 <djeks922@gmail.com>
Co-authored-by: Frederike Ramin <frederike.ramin@digitalservice.bund.de>
profnandaa
force-pushed
the
mcfix/combined-prs
branch
from
4b06c0e to
c6f2196
Compare
2 participants
This is a clean-up PR for other PRs that had merge-conflicts, especially on README.