Merged
Conversation
This comment has been minimized.
This comment has been minimized.
1 task
Gudahtt
added a commit
to Gudahtt/berry
that referenced
this pull request
Feb 9, 2026
…lowlist * origin/master: (212 commits) CI: Select node version to run CI against automatically (yarnpkg#7032) Fixes foreach order when --topological isnt set (yarnpkg#6997) fix(fslib): handle float timestamps in convertToBigIntStats (yarnpkg#6988) Fixes the `/<name>/<version>` format (yarnpkg#6993) docs(constraints): add missing @typedef alias for `Context` (yarnpkg#6989) Sync master with the changes from master Releasing 3 new packages Fix JSON Schema (yarnpkg#6973) Implements npm web login support (yarnpkg#6981) fix(git): split `-c` and `core.autocrlf=false` into separate args for `clone` (yarnpkg#6983) Sync master with the changes from master Releasing 8 new packages Allow catalogs to work with descriptors without resolvers (yarnpkg#6930) docs: Clarify additional use-case of npmMinimalAgeGate (yarnpkg#6945) Migrates the "typescript" dependencies to a catalog (yarnpkg#6969) Support escaping template variables in environment values (yarnpkg#6935) Core: Create DURATION settings type (yarnpkg#6942) fix: use correct env var to detect gitlab CI for OIDC (yarnpkg#6938) Update README.md badge link (yarnpkg#6947) fix(publish): use correct workspace name in --json output (yarnpkg#6949) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
There are a number of configurations that represent a duration of time (e.g.
httpTimeout). Currently those use theNUMBERsettings type with a predefined unit (e.g. milliseconds forhttpTimeout). But:How did you fix it?
Create a new
DURATIONsettings type that allows specifying the duration as a string in the following format:ms,s,m,h,d,wFor backward compatibility, a
DURATIONis parsed to a number using the existing predefined unit for that setting. That unit is also used if one is not specified.I have only implemented units that the exactly convertible to each other* to avoid something like having to convert 1 month to an exact number of days.
(* not entirely true since 1 day is not always 24 hours)
In the future, maybe we can use a proper duration data structure to do proper date calculations. (So that, for example, setting a DURATION to 1 month actually means "1 calendar month" instead of an approximate number of seconds)
Checklist