Skip to content

fix(git): split -c and core.autocrlf=false into separate args for clone#6983

Merged
arcanis merged 1 commit intoyarnpkg:masterfrom
mhassan1:fix-git-autocrlf-arg
Nov 20, 2025
Merged

fix(git): split -c and core.autocrlf=false into separate args for clone#6983
arcanis merged 1 commit intoyarnpkg:masterfrom
mhassan1:fix-git-autocrlf-arg

Conversation

@mhassan1
Copy link
Contributor

What's the problem this PR addresses?

This PR fixes a bug when calling git clone with Git 2.52.0; currently, Yarn is executing git clone "-c core.autocrlf=false" ..., instead of the intended git clone -c core.autocrlf=false ..., and Git 2.52.0 does not like the quoted version.

Resolves #6982.

How did you fix it?

This splits -c core.autocrlf=false into separate arguments.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@mhassan1 mhassan1 force-pushed the fix-git-autocrlf-arg branch from 5cfdbff to 8f16246 Compare November 20, 2025 14:30
Copy link

@bert-mccutchen bert-mccutchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes the same issue that we are having after upgrading to Git 2.52.0.

@arcanis arcanis merged commit 0b3462a into yarnpkg:master Nov 20, 2025
26 checks passed
@arcanis
Copy link
Member

arcanis commented Nov 20, 2025

Thanks!

Gudahtt added a commit to Gudahtt/berry that referenced this pull request Feb 9, 2026
…lowlist

* origin/master: (212 commits)
  CI: Select node version to run CI against automatically (yarnpkg#7032)
  Fixes foreach order when --topological isnt set (yarnpkg#6997)
  fix(fslib): handle float timestamps in convertToBigIntStats (yarnpkg#6988)
  Fixes the `/<name>/<version>` format (yarnpkg#6993)
  docs(constraints): add missing @typedef alias for `Context` (yarnpkg#6989)
  Sync master with the changes from master
  Releasing 3 new packages
  Fix JSON Schema (yarnpkg#6973)
  Implements npm web login support (yarnpkg#6981)
  fix(git): split `-c` and `core.autocrlf=false` into separate args for `clone` (yarnpkg#6983)
  Sync master with the changes from master
  Releasing 8 new packages
  Allow catalogs to work with descriptors without resolvers (yarnpkg#6930)
  docs: Clarify additional use-case of npmMinimalAgeGate (yarnpkg#6945)
  Migrates the "typescript" dependencies to a catalog (yarnpkg#6969)
  Support escaping template variables in environment values (yarnpkg#6935)
  Core: Create DURATION settings type (yarnpkg#6942)
  fix: use correct env var to detect gitlab CI for OIDC (yarnpkg#6938)
  Update README.md badge link (yarnpkg#6947)
  fix(publish): use correct workspace name in --json output (yarnpkg#6949)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: Git 2.52.0 breaks git protocol

3 participants