Skip to content

fix: blank expanded dimension table while data loads — show a spinner in DimensionTable - #9677

Merged
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-expanded-dimension-table-spinner
Jul 15, 2026
Merged

fix: blank expanded dimension table while data loads — show a spinner in DimensionTable#9677
nishantmonu51 merged 1 commit into
mainfrom
nishant/fix-expanded-dimension-table-spinner

Conversation

@nishantmonu51

Copy link
Copy Markdown
Collaborator
  • Since Fix DimensionTable virtualized jankiness #8320 added contain: content to the virtualizer grid in DimensionTable.svelte, the Loading... and No results to show states have been clipped and invisible: with no rows, the grid is only header-height, and the text sat below it at mt-[30vh]. Expanding a dimension on a large dataset therefore showed a completely blank table until the query returned.
  • Moved the empty/loading state out of the clipped virtualizer div into a centered overlay on the table container.
  • While fetching, show a DelayedSpinner (same pattern as leaderboard headers; 300ms delay so fast loads don't flicker). The No results to show empty state is visible again as well.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51

Copy link
Copy Markdown
Collaborator Author

@codex: review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: b8202c194c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nishantmonu51 nishantmonu51 added Type:Bug Something isn't working Area:Dashboard Size:S Small change: under 100 lines labels Jul 14, 2026
@nishantmonu51
nishantmonu51 merged commit 48bca86 into main Jul 15, 2026
16 checks passed
@nishantmonu51
nishantmonu51 deleted the nishant/fix-expanded-dimension-table-spinner branch July 15, 2026 05:12
nishantmonu51 added a commit that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area:Dashboard Size:S Small change: under 100 lines Type:Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants