chore: replace FQNs with imports, Junit best practices

[robfrank]

What does this PR do?

remove FQNs in favor of imports

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code readability and maintainability by refactoring Java import statements and class references. It systematically replaces fully qualified names (FQNs) with their simpler counterparts after introducing explicit import statements or consolidating multiple imports into wildcard declarations. This change primarily affects how classes from java.util, java.util.concurrent, java.util.logging, java.time, com.arcadedb.schema, com.arcadedb.exception, com.arcadedb.graph, and org.assertj.core.data are referenced throughout the codebase, making the code cleaner and easier to follow.

Highlights

• Code Readability: Improved code readability across multiple modules by replacing verbose fully qualified names (FQNs) with simpler, imported class names.
• Import Optimization: Optimized import statements by adding specific imports for classes previously referenced with their full package paths, and in some cases, consolidated multiple imports into wildcard imports for better conciseness.
• Consistency: Applied consistent refactoring across the bolt, engine, and server modules to standardize the use of imports and FQNs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• bolt/src/test/java/com/arcadedb/bolt/BoltEdgeCreationPerformanceIT.java
  • Removed fully qualified names for Type and Level by adding explicit imports.
• engine/src/main/java/com/arcadedb/graph/GraphBatchImporter.java
  • Removed fully qualified name for HashSet by adding an explicit import.
• engine/src/main/java/com/arcadedb/graph/olap/CSRBuilder.java
  • Consolidated schema-related imports into a wildcard and removed fully qualified name for Type.
• engine/src/main/java/com/arcadedb/graph/olap/DeltaCollector.java
  • Removed fully qualified name for DatabaseIsClosedException by adding an explicit import.
• engine/src/main/java/com/arcadedb/graph/olap/GraphAlgorithms.java
  • Removed fully qualified name for PriorityQueue by adding an explicit import.
• engine/src/main/java/com/arcadedb/graph/olap/GraphAnalyticalView.java
  • Consolidated java.util.concurrent imports and removed FQNs for RejectedExecutionException and Arrays.asList.
• engine/src/main/java/com/arcadedb/query/opencypher/executor/steps/MatchRelationshipStep.java
  • Removed fully qualified name for Arrays.toString by adding an explicit import.
• engine/src/main/java/com/arcadedb/query/opencypher/procedures/algo/AlgoDijkstraSingleSource.java
  • Consolidated com.arcadedb.graph.olap imports and removed FQN for GraphAlgorithms.
• engine/src/test/java/com/arcadedb/EdgeCreationCommitProfileTest.java
  • Removed fully qualified names for List and ArrayList by adding explicit imports.
• engine/src/test/java/com/arcadedb/graph/olap/GraphAlgorithmsTest.java
  • Removed fully qualified name for Offset by adding an explicit import.
• engine/src/test/java/com/arcadedb/graph/olap/GraphAnalyticalViewTest.java
  • Removed fully qualified names for various utility classes, concurrent classes, schema types, and JSON objects by adding explicit imports or using shorter names after wildcard imports.
• engine/src/test/java/com/arcadedb/graph/olap/simd/GraphOlapVectorOpsTest.java
  • Removed fully qualified name for Arrays.fill by adding an explicit import.
• engine/src/test/java/com/arcadedb/query/opencypher/MatchRelationshipStepOptimizationTest.java
  • Removed fully qualified names for List and ArrayList by adding explicit imports.
• engine/src/test/java/com/arcadedb/query/opencypher/procedures/algo/AlgoPageRankTest.java
  • Removed fully qualified name for Offset by adding an explicit import.
• engine/src/test/java/com/arcadedb/query/opencypher/procedures/algo/AlgoSLPATest.java
  • Removed fully qualified name for Vertex by adding an explicit import.
• server/src/main/java/com/arcadedb/server/ai/AiChatHandler.java
  • Removed fully qualified name for Instant by adding an explicit import.
• server/src/main/java/com/arcadedb/server/ai/AiChatsHandler.java
  • Removed fully qualified name for Instant by adding an explicit import.
• server/src/main/java/com/arcadedb/server/ai/AiConfiguration.java
  • Removed fully qualified name for Instant by adding an explicit import.
• server/src/main/java/com/arcadedb/server/ai/ChatStorage.java
  • Removed fully qualified name for Instant by adding an explicit import.
• server/src/test/java/com/arcadedb/server/ai/ChatStorageTest.java
  • Removed fully qualified name for Instant by adding an explicit import.

Activity

• No specific activity or comments were provided in the pull request description beyond the initial template.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for ddfd25c.

🟢 All jobs passed!

But CI Insights is watching 👀

[claude]

Good cleanup - replacing FQNs with proper imports aligns with the CLAUDE.md guideline. Minor issue: 4 files introduce wildcard imports (CSRBuilder.java uses 'import com.arcadedb.schema.;', GraphAnalyticalView.java uses 'import java.util.concurrent.;', AlgoDijkstraSingleSource.java uses 'import com.arcadedb.graph.olap.;', GraphAnalyticalViewTest.java uses 'import java.util.;') instead of explicit per-class imports. The guideline implies explicit single-type imports - wildcards hide actual dependencies and complicate refactoring. Also, the PR description still has the boilerplate template text. All other changes look correct. Reviewed by Claude Code.

[gemini-code-assist]

Code Review

This pull request consists of a codebase-wide refactoring to replace fully qualified names with imports. These changes improve code readability and maintainability. The modifications are consistent and have been applied correctly across all affected files. My review did not identify any issues or areas for further improvement.

[claude]

Code Review

Overall this is a clean housekeeping PR that aligns with the project guideline: do not use fully qualified names, always import the class and just use the name. The changes are correct and purely cosmetic.

Positive observations

• Removing inline FQNs (e.g. com.arcadedb.schema.Type.INTEGER, java.util.logging.Level.INFO) is exactly what the style guide asks for.
• Switching test class visibility from public class to package-private and dropping the test prefix from method names is good JUnit 5 practice consistent with the rest of the suite.
• No logic was touched, so there is no functional risk.

Wildcard imports in production code

Three files replace a small number of individual imports with wildcard (*) imports:

• CSRBuilder.java: import com.arcadedb.schema.*; (replaces 4 named imports)
• GraphAnalyticalView.java: import java.util.concurrent.*; (replaces 5 named imports)
• AlgoDijkstraSingleSource.java: import com.arcadedb.graph.olap.*; (replaces 4 named imports)

While the project already uses java.util.concurrent.* in several other files, wildcards for project-internal packages (com.arcadedb.schema.*, com.arcadedb.graph.olap.*) make it harder to see at a glance what is actually imported and can silently pull in new symbols as those packages grow. Explicit imports are generally preferable for project-internal packages.

Mixed wildcard style in GraphAnalyticalViewTest.java

The file replaces ArrayList, Collections, and List with import java.util.*; while keeping specific sub-imports from java.util.concurrent on separate lines. Prefer either explicit imports throughout or a wildcard for each package, not both.

Summary

The PR is good as-is if the team is comfortable with the existing wildcard-import pattern. The only things worth revisiting before merging are the three wildcard imports for project-internal packages (CSRBuilder, GraphAnalyticalView, AlgoDijkstraSingleSource).

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -9.86%	✅ 23.81%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (5755dd8)	109689	81927	74.69%
Head commit (ddfd25c)	140633 (+30944)	91167 (+9240)	64.83% (-9.86%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3665)	21	5	23.81%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[codecov]

Codecov Report

❌ Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.33%. Comparing base (5755dd8) to head (ddfd25c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ain/java/com/arcadedb/server/ai/AiChatHandler.java	0.00%	5 Missing ⚠️
...a/com/arcadedb/graph/olap/GraphAnalyticalView.java	42.85%	4 Missing ⚠️
...n/java/com/arcadedb/graph/olap/DeltaCollector.java	0.00%	2 Missing ⚠️
.../java/com/arcadedb/graph/olap/GraphAlgorithms.java	0.00%	1 Missing ⚠️
...encypher/executor/steps/MatchRelationshipStep.java	0.00%	1 Missing ⚠️
...pher/procedures/algo/AlgoDijkstraSingleSource.java	0.00%	1 Missing ⚠️
...in/java/com/arcadedb/server/ai/AiChatsHandler.java	0.00%	1 Missing ⚠️
...n/java/com/arcadedb/server/ai/AiConfiguration.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
- Coverage   65.84%   65.33%   -0.52%     
==========================================
  Files        1550     1550              
  Lines      109689   109689              
  Branches    22875    22875              
==========================================
- Hits        72229    71664     -565     
- Misses      27789    28376     +587     
+ Partials     9671     9649      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.