remove underscores from funciont name mppping

[robfrank]

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.

Additional Notes

Anything else we should know when reviewing?

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant refactoring of Cypher function names, transitioning from an underscore-separated convention to a dot-separated one. The primary goal is to enhance consistency and readability within the Cypher query language implementation. This change involved updating how functions are registered, parsed, and executed, along with corresponding adjustments to test cases to ensure the system remains robust and functional under the new naming scheme.

Highlights

• Function Naming Standardization: Standardized Cypher function names by replacing underscores with dots (e.g., 'vector_create' became 'vector.create', 'char_length' became 'char.length') across the codebase.
• Function Mapping Updates: Updated the CypherFunctionFactory to correctly map the new dot-separated function names to their respective stateless function implementations.
• Parser and Validator Alignment: Adjusted the CypherExpressionBuilder and FunctionValidator to recognize and correctly process the new dot-separated function naming convention.
• Test Case Refactoring: Modified existing test cases to reflect the new function names in Cypher queries, ensuring continued functionality and correctness.
• Import Statement Refinement: Replaced wildcard import statements with explicit, individual class imports in CypherFunctionFactory for improved code clarity and maintainability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[claude]

Code Review

Thanks for the cleanup. Standardizing to dot notation is consistent with the existing pattern used by vector.norm, vector.distance.euclidean, date.truncate, etc. The explicit imports replacing wildcards are also a nice improvement for clarity.

That said, I have a few concerns:

---

Breaking Change: char_length / character_length are GQL/OpenCypher Standard Names

char_length and character_length are defined in the GQL ISO/IEC 39075 standard and referenced in OpenCypher specs. These aren't custom names — they are the canonical names for character-length functions in the standard. Renaming them to char.length / character.length breaks compatibility with:

• Any user code or stored queries using the standard names
• Tooling that generates standard Cypher/GQL queries

At minimum, the old names should be kept as aliases, or this change should be reconsidered entirely for these two functions.

---

Incomplete Backward Compatibility for Vector Functions

vector is kept as an alias for vector.create — good. But the other renamed functions lose their old names entirely:

• vector_create → only vector.create (no alias)
• vector_dimension_count → only vector.dimension.count (no alias)
• vector_distance → only vector.distance (no alias)
• vector_distance_manhattan → only vector.distance.manhattan (no alias)
• vector_distance_cosine → only vector.distance.cosine (no alias)

If these are considered non-standard/internal functions, removing the old names without aliases is a breaking change and should be called out explicitly in the release notes.

---

Incomplete PR Description

The PR description contains template placeholder text. Please describe the motivation (standardization with dot notation) and explicitly note which function names are being removed.

---

Positives

• Explicit imports replacing wildcards improve readability and IDE navigation
• Consolidation of vector_create and vector into a single case (case "vector", "vector.create") is clean
• Tests are updated consistently across all affected files
• The change is internally consistent across CypherFunctionFactory, CypherExpressionBuilder, FunctionValidator, and test files

[gemini-code-assist]

Code Review

This pull request consistently renames Cypher function mappings from using underscores (_) to dots (.) across CypherFunctionFactory.java, CypherExpressionBuilder.java, and FunctionValidator.java. The corresponding test cases in CypherMissingFunctionsTest.java and OpenCypherMissingFunctionsTest.java have also been updated to reflect these new function names. This change improves consistency in function naming conventions and is well-executed.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 2d0afdc1	✅ 80.95%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (2d0afdc)	Report Missing	Report Missing	Report Missing
Head commit (24d10d6)	142458	92285	64.78%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3681)	21	17	80.95%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[codecov]

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.10%. Comparing base (7a2a2b3) to head (24d10d6).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...ery/opencypher/executor/CypherFunctionFactory.java	80.00%	2 Missing ⚠️
...ery/opencypher/parser/CypherExpressionBuilder.java	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3681      +/-   ##
==========================================
- Coverage   65.82%   65.10%   -0.73%     
==========================================
  Files        1558     1558              
  Lines      111375   111514     +139     
  Branches    23383    23417      +34     
==========================================
- Hits        73313    72597     -716     
- Misses      28180    29085     +905     
+ Partials     9882     9832      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.