Add Clang system config action (15/24) - #23190
Merged
Merged
Conversation
MikeMcQuaid
force-pushed
the
install-step-14-glibc-runtime
branch
from
July 20, 2026 07:22
4620ad0 to
2fbea75
Compare
MikeMcQuaid
force-pushed
the
install-step-15-clang-system-config
branch
from
July 20, 2026 07:22
2aefaca to
83511f2
Compare
MikeMcQuaid
force-pushed
the
install-step-14-glibc-runtime
branch
from
July 21, 2026 07:14
2fbea75 to
46ec0ad
Compare
MikeMcQuaid
force-pushed
the
install-step-15-clang-system-config
branch
from
July 21, 2026 07:14
83511f2 to
2850010
Compare
MikeMcQuaid
force-pushed
the
install-step-14-glibc-runtime
branch
2 times, most recently
from
July 26, 2026 17:13
d5ef087 to
d39b823
Compare
MikeMcQuaid
force-pushed
the
install-step-15-clang-system-config
branch
from
July 26, 2026 18:30
2850010 to
36c7752
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new configure_clang_system install-step action to generate macOS Clang target configuration (.cfg) files under etc/clang, and wires it into the InstallSteps DSL, RuboCop allowlists, tests, and documentation.
Changes:
- Add
Utils::Clang.write_system_config_filesto emit per-target.cfgfiles pointing at the CLT SDK sysroot. - Add a new InstallSteps DSL action (
configure_clang_system) plus Runner dispatch and a corresponding formula action implementation. - Update RuboCop allowlists, add RSpec coverage, and document the new action in the Formula Cookbook.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/utils/clang.rb | New utility to write Clang target config files for multiple architectures and system/version pairs. |
| Library/Homebrew/test/utils/clang_spec.rb | Adds a unit spec for the new config file generator. |
| Library/Homebrew/test/rubocops/install_steps_spec.rb | Updates RuboCop expectations to allow configure_clang_system in steps blocks. |
| Library/Homebrew/test/install_steps_spec.rb | Adds a dispatch test ensuring the new DSL step routes to the Runner method. |
| Library/Homebrew/rubocops/shared/install_steps_helper.rb | Adds configure_clang_system to the list of allowed formula action step methods. |
| Library/Homebrew/install_steps/formula_actions.rb | Implements run_configure_clang_system to generate configs on macOS when needed. |
| Library/Homebrew/install_steps.rb | Adds the DSL method and Runner case dispatch for configure_clang_system. |
| docs/Formula-Cookbook.md | Documents the new action in the cookbook’s “formula action steps” list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
force-pushed
the
install-step-15-clang-system-config
branch
from
July 26, 2026 19:15
36c7752 to
acff6a4
Compare
Four LLVM and Clang formulae share macOS target configuration generation for the active SDK and kernel versions. - skip non-macOS installs and generated native configurations - select the current or versioned Command Line Tools SDK - emit compatible arm64, aarch64 and x86_64 target files
MikeMcQuaid
force-pushed
the
install-step-15-clang-system-config
branch
from
July 27, 2026 07:10
acff6a4 to
b312752
Compare
MikeMcQuaid
marked this pull request as ready for review
July 29, 2026 13:28
p-linnane
approved these changes
Jul 29, 2026
dduugg
added a commit
that referenced
this pull request
Jul 30, 2026
Main added the `configure_glibc_runtime` and `configure_clang_system` install-steps DSL methods (#23201, #23190). They are formula-facing DSL with no in-repo caller, like their siblings, so mark them `@api internal` to keep brew deadcode idempotent. Claude-Session: https://claude.ai/code/session_011BgWRBydtdkvt8ocqH4nj9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four LLVM and Clang formulae share macOS target configuration generation
for the active SDK and kernel versions.
AI disclosure: using OpenAI Codex 5.6 Sol max with local review and
testing.