Add glibc runtime action (14/24) - #23201
Merged
Merged
Conversation
MikeMcQuaid
force-pushed
the
install-step-13-gzipped-executables
branch
from
July 20, 2026 07:22
e5f68fb to
fa41de0
Compare
MikeMcQuaid
force-pushed
the
install-step-14-glibc-runtime
branch
from
July 20, 2026 07:22
4620ad0 to
2fbea75
Compare
MikeMcQuaid
force-pushed
the
install-step-13-gzipped-executables
branch
from
July 21, 2026 07:14
fa41de0 to
65c8140
Compare
MikeMcQuaid
force-pushed
the
install-step-14-glibc-runtime
branch
from
July 21, 2026 07:14
2fbea75 to
46ec0ad
Compare
MikeMcQuaid
force-pushed
the
install-step-13-gzipped-executables
branch
from
July 26, 2026 15:46
65c8140 to
f8711ab
Compare
MikeMcQuaid
force-pushed
the
install-step-14-glibc-runtime
branch
from
July 26, 2026 16:16
46ec0ad to
d5ef087
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new install-steps “formula action” to configure glibc-family runtime state (locale generation and timezone link setup), and wires it into the install steps DSL, runner dispatch, RuboCop auditing, tests, and documentation.
Changes:
- Introduces
configure_glibc_runtimeas an install-step DSL action and adds runner support (run_configure_glibc_runtime). - Extends RuboCop’s allowed install-step method list and updates related RuboCop specs.
- Adds a dispatch spec for the new action and documents the repeated action in the Formula Cookbook.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/test/rubocops/install_steps_spec.rb | Updates RuboCop cop specs to include the new DSL action in allowed methods. |
| Library/Homebrew/test/install_steps_spec.rb | Adds a spec asserting runner dispatch for the new configure_glibc_runtime step. |
| Library/Homebrew/rubocops/shared/install_steps_helper.rb | Allows configure_glibc_runtime within post_install_steps blocks. |
| Library/Homebrew/install_steps/formula_actions.rb | Implements run_configure_glibc_runtime to generate locales and set timezone-related symlinks. |
| Library/Homebrew/install_steps.rb | Adds DSL method configure_glibc_runtime and runner dispatch case. |
| docs/Formula-Cookbook.md | Documents the new repeated action (but currently with a name mismatch). |
Comments suppressed due to low confidence (2)
Library/Homebrew/install_steps/formula_actions.rb:114
run_configure_glibc_runtimecreateslib/localebut doesn’t ensure the parent directories for the timezone symlink targets exist.File.symlinkwill raiseErrno::ENOENTifcontext_path("etc")orcontext_path("share")don’t already exist.
[[Pathname("/etc/localtime"), context_path("etc")/"localtime"],
[Pathname("/usr/share/zoneinfo"), context_path("share")/"zoneinfo"]].each do |source, target|
File.symlink source, target if source.exist? && !target.exist?
end
Library/Homebrew/install_steps/formula_actions.rb:105
- Charmap normalisation only handles the exact lowercase string "utf8". To reliably normalise common variants (e.g. "UTF8", "utf-8"), compare case-insensitively after removing dashes.
if charmap.present?
charmap = "UTF-8" if charmap == "utf8"
run_command context_path("bin")/"localedef", "-i", lang, "-f", charmap, locale
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
force-pushed
the
install-step-13-gzipped-executables
branch
from
July 26, 2026 17:13
f8711ab to
a959228
Compare
Three glibc-family formulae share locale generation and timezone-link setup with different rules for the legacy variants. - derive requested locales while always providing the UTF-8 default - invoke the installed `localedef` with normalised charmaps - preserve host timezone links when their sources exist
MikeMcQuaid
force-pushed
the
install-step-14-glibc-runtime
branch
from
July 26, 2026 17:13
d5ef087 to
d39b823
Compare
MikeMcQuaid
marked this pull request as ready for review
July 29, 2026 13:28
p-linnane
approved these changes
Jul 29, 2026
dduugg
added a commit
that referenced
this pull request
Jul 30, 2026
Main added the `configure_glibc_runtime` and `configure_clang_system` install-steps DSL methods (#23201, #23190). They are formula-facing DSL with no in-repo caller, like their siblings, so mark them `@api internal` to keep brew deadcode idempotent. Claude-Session: https://claude.ai/code/session_011BgWRBydtdkvt8ocqH4nj9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three glibc-family formulae share locale generation and timezone-link
setup with different rules for the legacy variants.
localedefwith normalised charmapsAI disclosure: using OpenAI Codex 5.6 Sol max with local review and
testing.