Skip to content

Main merge release/26.06 14 - #1374

Merged
ramakrishnap-nv merged 2 commits into
NVIDIA:mainfrom
ramakrishnap-nv:main-merge-release/26.06_14
Jun 3, 2026
Merged

Main merge release/26.06 14#1374
ramakrishnap-nv merged 2 commits into
NVIDIA:mainfrom
ramakrishnap-nv:main-merge-release/26.06_14

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

For #1373

ramakrishnap-nv and others added 2 commits June 3, 2026 01:01
cudss 0.8 had some speed-up regressions, so switching back to 0.7

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ishika Roy (https://github.com/Iroy30)

URL: NVIDIA#1371
@ramakrishnap-nv
ramakrishnap-nv requested review from a team as code owners June 3, 2026 01:04
@ramakrishnap-nv
ramakrishnap-nv requested review from Iroy30 and bdice June 3, 2026 01:04
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d478f4c4-f4ad-4804-a050-91f08390172a

📥 Commits

Reviewing files that changed from the base of the PR and between 9e14310 and 409f5ef.

📒 Files selected for processing (9)
  • ci/utils/install_cudss.sh
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • conda/environments/all_cuda-132_arch-aarch64.yaml
  • conda/environments/all_cuda-132_arch-x86_64.yaml
  • conda/recipes/libcuopt/recipe.yaml
  • cpp/cmake/thirdparty/FindCUDSS.cmake
  • dependencies.yaml
  • python/libcuopt/pyproject.toml

📝 Walkthrough

Walkthrough

This PR uniformly downgrades cuDSS dependency constraints from the 0.8.x series to the 0.7.x series across the entire project. The change affects CI installation logic, CMake package discovery, central dependency declarations, conda environment specifications, conda recipe packaging, and Python project metadata.

Changes

cuDSS version pinning update

Layer / File(s) Summary
Central dependency configuration and wheel/conda pins
dependencies.yaml
Central conda and wheel dependency constraints updated from >=0.8,<0.9 to >=0.7,<0.8 for libcudss-dev, nvidia-cudss-cu12, and nvidia-cudss-cu13 across CUDA 12 and CUDA 13 variants.
CI installation and CMake build discovery
ci/utils/install_cudss.sh, cpp/cmake/thirdparty/FindCUDSS.cmake
Installation script package globs and version constraints updated to 0.7.*, and CMake find_package minimum version lowered from 0.8 to 0.7 for unpinned CUDSS_DIR discovery path.
Conda environments and recipe packaging
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-129_arch-x86_64.yaml, conda/environments/all_cuda-132_arch-aarch64.yaml, conda/environments/all_cuda-132_arch-x86_64.yaml, conda/recipes/libcuopt/recipe.yaml
All four conda environment libcudss-dev constraints updated to >=0.7,<0.8; libcuopt recipe top-level host, per-package host, runtime, and test host requirements updated to the 0.7.x series.
Python project dependency
python/libcuopt/pyproject.toml
Python project nvidia-cudss-cu13 dependency updated to >=0.7,<0.8.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • NVIDIA/cuopt#1371: Both PRs update the same cuDSS version pins from >=0.8,<0.9 to >=0.7,<0.8 across identical files.
  • NVIDIA/cuopt#1360: Both PRs align cuDSS to the 0.7.x line with overlapping changes to ci/utils/install_cudss.sh and related dependency specifications.
  • NVIDIA/cuopt#1365: Both PRs modify the same cuDSS version pin points across multiple files but shift them in opposite directions.

Suggested labels

non-breaking, improvement

Suggested reviewers

  • bdice
  • Iroy30
  • tmckayus
  • jakirkham
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Main merge release/26.06 14' is a generic merge commit message that does not describe the actual technical change being made (pinning cuDSS to 0.7.x). Retitle to something like 'Pin cuDSS dependencies to 0.7.x series' to clearly communicate the main change across all modified files.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description references issue #1373, which relates to the changeset purpose, though minimal detail is provided it remains related to the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 3, 2026
@ramakrishnap-nv
ramakrishnap-nv merged commit f63c156 into NVIDIA:main Jun 3, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant