Assorted improvements - #354
Merged
Merged
Conversation
Lysxia
reviewed
Jul 1, 2021
|
Thanks, as always, for the many improvements @Bodigrim! |
Lysxia
approved these changes
Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data.Text.Internal.Functionsintext-1.2.4.1contains only one functionintersperse, whose definition actually matchesData.Listsincebase-4.4. It makes no sense to carry on with this module.unsafeWithForeignPtrwas added to the same module in #325, but this change has not been released yet, and I thinkData.Text.Internal.Unsafeis a better place for such function.I discovered that our tests intentionally disable rewrite rules. This is extremely weird, because it means that rewrite rules (which are always enabled for users) remain completely untested. I don't know good reasons to test configuration with disabled rules, so I enabled them unconditionally. Potentially we can add a dedicated CI build with
cabal test --ghc-option=-fno-enable-rewrite-rules, but I'm not sure it's worth it.wordswere unlikely to be thoroughly tested before; I've added a special QuickCheck generator, which creates strings with many interestring space characters. I also written some additional tests for other functions.I was looking for Apple Silicon CI, but it seems there are no free services of this kind so far. So I added drone.io for Ubuntu ARM build, which is better than nothing. E. g., https://cloud.drone.io/Bodigrim/text/4/1/2