avoid overlapping const suggestions - #161411
Merged
Merged
Conversation
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
nnethercote
approved these changes
Aug 25, 2026
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 25, 2026
avoid overlapping const suggestions Avoid emitting the optional `const-extraction` suggestion when its **component spans** overlap, this avoids the compiler panic while still emitting the normal error and keeping the suggestion for cases where it can be generated correctly Fixes rust-lang#161213
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
Rollup of 5 pull requests Successful merges: - #156749 (remove `box_patterns`) - #161411 (avoid overlapping const suggestions) - #161484 (Discard `.pdr` in the PSP linker script) - #161663 (Reduce dependency on implicit paths in bootstrap) - #161720 (rename rust_target_features query to make it clear that these are *all* target features)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
Rollup merge of #161411 - im-lunex:fix_#161213, r=nnethercote avoid overlapping const suggestions Avoid emitting the optional `const-extraction` suggestion when its **component spans** overlap, this avoids the compiler panic while still emitting the normal error and keeping the suggestion for cases where it can be generated correctly Fixes #161213
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Aug 26, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#156749 (remove `box_patterns`) - rust-lang/rust#161411 (avoid overlapping const suggestions) - rust-lang/rust#161484 (Discard `.pdr` in the PSP linker script) - rust-lang/rust#161663 (Reduce dependency on implicit paths in bootstrap) - rust-lang/rust#161720 (rename rust_target_features query to make it clear that these are *all* target features)
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 28, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#156749 (remove `box_patterns`) - rust-lang/rust#161411 (avoid overlapping const suggestions) - rust-lang/rust#161484 (Discard `.pdr` in the PSP linker script) - rust-lang/rust#161663 (Reduce dependency on implicit paths in bootstrap) - rust-lang/rust#161720 (rename rust_target_features query to make it clear that these are *all* target features)
vetleras
pushed a commit
to vetleras/rustfmt
that referenced
this pull request
Aug 28, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#156749 (remove `box_patterns`) - rust-lang/rust#161411 (avoid overlapping const suggestions) - rust-lang/rust#161484 (Discard `.pdr` in the PSP linker script) - rust-lang/rust#161663 (Reduce dependency on implicit paths in bootstrap) - rust-lang/rust#161720 (rename rust_target_features query to make it clear that these are *all* target features)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid emitting the optional
const-extractionsuggestion when its component spans overlap, this avoids the compiler panic while still emitting the normal error and keeping the suggestion for cases where it can begenerated correctly
Fixes #161213