Reduce dependency on implicit paths in bootstrap - #161663

Kobzol · 2026-08-24T10:38:38Z

Minor drive-by cleanup, reducing usage of some shared directories, and replacing it with depending on explicit paths.

Also found some env. vars. that I think have been unused for a long time.

r? jieyouxu

And instead explicitly depend on the output of the `TestHelpers` step.

It doesn't seem to be used anywhere anymore.

It was only used at one place.

And instead depend on the generated md doc directory path explicitly.

jieyouxu

Thanks, r=me with or without a remark.
@rustbot author

View changes since this review

Kobzol · 2026-08-25T06:30:21Z

@bors r=jieyouxu rollup

I think that the test targets thing is a separate item that we can do in a follow-up, if there's some cleanup to do. Feel free to r- if you want to block this PR on that!

rust-bors · 2026-08-25T06:30:24Z

📌 Commit 5e43efd has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2026-08-25T06:30:56Z

No need -- I was moreso recalling that test_helpers was another quirky thing

…=jieyouxu Reduce dependency on implicit paths in bootstrap Minor drive-by cleanup, reducing usage of some shared directories, and replacing it with depending on explicit paths. Also found some env. vars. that I think have been unused for a long time. r? jieyouxu

Rollup of 5 pull requests Successful merges: - #156749 (remove `box_patterns`) - #161411 (avoid overlapping const suggestions) - #161484 (Discard `.pdr` in the PSP linker script) - #161663 (Reduce dependency on implicit paths in bootstrap) - #161720 (rename rust_target_features query to make it clear that these are *all* target features)

Rollup merge of #161663 - Kobzol:bootstrap-explicit-paths, r=jieyouxu Reduce dependency on implicit paths in bootstrap Minor drive-by cleanup, reducing usage of some shared directories, and replacing it with depending on explicit paths. Also found some env. vars. that I think have been unused for a long time. r? jieyouxu

Rollup of 5 pull requests Successful merges: - rust-lang/rust#156749 (remove `box_patterns`) - rust-lang/rust#161411 (avoid overlapping const suggestions) - rust-lang/rust#161484 (Discard `.pdr` in the PSP linker script) - rust-lang/rust#161663 (Reduce dependency on implicit paths in bootstrap) - rust-lang/rust#161720 (rename rust_target_features query to make it clear that these are *all* target features)

Kobzol added 5 commits August 24, 2026 11:30

Remove the test_helpers_out function

215d10d

And instead explicitly depend on the output of the `TestHelpers` step.

Remove unused RUSTBUILD_NATIVE_DIR environment variable

b5d79cd

It doesn't seem to be used anywhere anymore.

Remove unused RUSTC_ERROR_METADATA_DST environment variable

a674697

It doesn't seem to be used anywhere anymore.

Remove the test_out function

f45f543

It was only used at one place.

Remove the md_doc_out function

5e43efd

And instead depend on the generated md doc directory path explicitly.

rustbot assigned jieyouxu Aug 24, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 24, 2026

jieyouxu approved these changes Aug 25, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/build_steps/test.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2026

JonathanBrouwer mentioned this pull request Aug 25, 2026

Rollup of 4 pull requests #161722

Closed

jhpratt mentioned this pull request Aug 25, 2026

Rollup of 5 pull requests #161731

Merged

rust-bors Bot merged commit 2cb532c into rust-lang:main Aug 25, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Aug 25, 2026

Kobzol deleted the bootstrap-explicit-paths branch August 25, 2026 12:00

Navigation Menu

Uh oh!

Uh oh!

Reduce dependency on implicit paths in bootstrap - #161663