Database mvc refactoring - #1604
Conversation
…d integrated changes properly
Pull Request Test Coverage Report for Build d3596bda-9058-481b-b883-c434b7c1601bDetails
💛 - Coveralls |
david-yz-liu
left a comment
There was a problem hiding this comment.
@akarki2005 this is great. I realized that you and @matt-dahlgren have used slightly different names for the controller (see #1603).
Overall I think "Program" is better than "Post" for the codebase, so please do a bit more refactoring to switch from "Post" to "Program" in both the files and function/variable names. But, you can leave the database table and route names the same, as those are a bit more work to change.
… into database-mvc-refactoring
…s and route names
|
Hi @david-yz-liu, I have made the requested changes. :) I noticed that you pointed out that changing the database table names would be complex, I assume due to the database migration necessitated by a schema change. I was wondering if this was something I could tackle in a future PR, as I am currently enrolled in CSC343 and would love to get some practical experience with schema evolution! |
david-yz-liu
left a comment
There was a problem hiding this comment.
Nice work, @akarki2005!
Proposed Changes
This change further advances Courseography's shift to an MVC architecture by refactoring functions in the
Databasefolder pertaining to course querying and insertion into well-defined model and controller files.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: