Skip to content

Initialize Schema Version Table - #1616

Merged
david-yz-liu merged 8 commits into
Courseography:masterfrom
akarki2005:introduce-schema-version-table
Oct 20, 2025
Merged

Initialize Schema Version Table#1616
david-yz-liu merged 8 commits into
Courseography:masterfrom
akarki2005:introduce-schema-version-table

Conversation

@akarki2005

@akarki2005 akarki2005 commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Proposed Changes

This PR introduces a schema version table within Tables.hs, and updates the setupDatabase function in Database.hs to initialize the schema version table on database creation.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • [N/A] I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • [N/A] I have updated the project documentation, if applicable.
    • This is required for new features.
  • [N/A] If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

@coveralls

coveralls commented Oct 17, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 10c4d32c-2354-4429-a5a9-6b7e7976e868

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 55.118%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Database/Database.hs 9 10 90.0%
Totals Coverage Status
Change from base Build 90422179-6c02-4cf7-96d4-25cee8380b76: 0.06%
Covered Lines: 2217
Relevant Lines: 3948

💛 - Coveralls

Comment thread app/Database/Database.hs Outdated
Comment thread app/Database/Database.hs Outdated
Comment thread app/Database/Database.hs Outdated
@akarki2005

akarki2005 commented Oct 19, 2025

Copy link
Copy Markdown
Contributor Author

Hi David, I've made the requested changes, but my CI checks are now failing in the Install Package Dependencies step with this error message:

--2025-10-19 18:48:58--  https://imagemagick.org/archive/binaries/magick
Resolving imagemagick.org (imagemagick.org)... 50.251.58.13
Connecting to imagemagick.org (imagemagick.org)|50.251.58.13|:443... connected.
Unable to establish SSL connection.

From this, I've deduced the corresponding step in our CI pipeline is sudo wget https://imagemagick.org/archive/binaries/magick. Based on the way other package dependencies are installed in that step, I think we can modify this line to sudo apt-get install -y imagemagick to avoid connection issues.

EDIT: I initially made a PR (#1618) to implement this change, then realized that doing so installs version 6 rather than 7 (an upgrade that was made intentionally in #1480). Would appreciate your thoughts on how to best go about resolving this issue!

EDIT 2: Nevermind, looks like the CI is working now 😅

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @akarki2005! I think there was a temporary server error with ImageMagick. I reran the tests and they pass now, so all good.

@david-yz-liu
david-yz-liu merged commit 894d9e4 into Courseography:master Oct 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants