Initialize Schema Version Table - #1616
Conversation
Pull Request Test Coverage Report for Build 10c4d32c-2354-4429-a5a9-6b7e7976e868Details
💛 - Coveralls |
|
Hi David, I've made the requested changes, but my CI checks are now failing in the From this, I've deduced the corresponding step in our CI pipeline is EDIT: I initially made a PR (#1618) to implement this change, then realized that doing so installs version 6 rather than 7 (an upgrade that was made intentionally in #1480). Would appreciate your thoughts on how to best go about resolving this issue! EDIT 2: Nevermind, looks like the CI is working now 😅 |
david-yz-liu
left a comment
There was a problem hiding this comment.
Nice work, @akarki2005! I think there was a temporary server error with ImageMagick. I reran the tests and they pass now, so all good.
Proposed Changes
This PR introduces a schema version table within
Tables.hs, and updates thesetupDatabasefunction inDatabase.hsto initialize the schema version table on database creation.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: