Skip to content

ignore tests with the GCC backend if we can't find libgccjit.so for the target - #160715

Open
folkertdev wants to merge 2 commits into
rust-lang:mainfrom
folkertdev:gcc-ignore-unsupported-targets
Open

ignore tests with the GCC backend if we can't find libgccjit.so for the target#160715
folkertdev wants to merge 2 commits into
rust-lang:mainfrom
folkertdev:gcc-ignore-unsupported-targets

Conversation

@folkertdev

@folkertdev folkertdev commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

Much like we ignore tests on targets that don't support certain properties, ignore a test or revision when the target is not supported by GCC, and GCC is the default codegen backend.

With this change we can remove many //@ ignore-backends: gcc (which I've left for later).

See also the conversation at #rustc-codegen-gcc > tidy error on building test with GCC on unsupported target.

r? jieyouxu
cc @GuillaumeGomez @antoyo

@rustbot

rustbot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc labels Aug 7, 2026
@rustbot

rustbot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 7, 2026
@folkertdev folkertdev changed the title Gcc ignore unsupported targets ignore tests with the GCC backend if we can't find libgccjit.so for it Aug 7, 2026
@folkertdev folkertdev mentioned this pull request Aug 7, 2026
Closed
2 tasks
@folkertdev folkertdev changed the title ignore tests with the GCC backend if we can't find libgccjit.so for it ignore tests with the GCC backend if we can't find libgccjit.so for the target Aug 7, 2026
@GuillaumeGomez

GuillaumeGomez commented Aug 7, 2026

Copy link
Copy Markdown
Member

Thanks for doing it! It allows to remove some ignore-backends: gcc instructions, so that makes me very happy. :)

@rust-bors

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu reviewed Aug 8, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a behavior question

View changes since this review

Comment thread src/tools/compiletest/src/cli.rs Outdated
Comment thread src/tools/compiletest/src/directives.rs Outdated
@folkertdev
folkertdev force-pushed the gcc-ignore-unsupported-targets branch from 4428b79 to 4fcb8ed Compare August 8, 2026 11:51
@rustbot

rustbot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jieyouxu
jieyouxu approved these changes Aug 8, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me after one residual nit

View changes since this review

Comment thread src/tools/compiletest/src/common.rs Outdated
@folkertdev
folkertdev force-pushed the gcc-ignore-unsupported-targets branch from 4fcb8ed to 5a5b84a Compare August 8, 2026 12:06
@folkertdev

folkertdev commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=jieyouxu

@rust-bors

rust-bors Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5a5b84a has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160715 - folkertdev:gcc-ignore-unsupported-…
fe9e8ee 
…targets, r=jieyouxu

ignore tests with the GCC backend if we can't find `libgccjit.so` for the target

<!-- homu-ignore:start -->

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.

Much like we ignore tests on targets that don't support certain properties, ignore a test or revision when the target is not supported by GCC, and GCC is the default codegen backend.

With this change we can remove many `//@ ignore-backends: gcc` (which I've left for later).

See also the conversation at [#rustc-codegen-gcc > tidy error on building test with GCC on unsupported target](https://rust-lang.zulipchat.com/#narrow/channel/386786-rustc-codegen-gcc/topic/tidy.20error.20on.20building.20test.20with.20GCC.20on.20unsupported.20target/with/615232618).

r? jieyouxu
cc @GuillaumeGomez @antoyo
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 8, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Aug 8, 2026
@bors
Auto merge of #160761 - JonathanBrouwer:rollup-VhQ1GtJ, r=JonathanBro…
771916f 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #160336 (Move attributes out of rustc_hir)
 - #160715 (ignore tests with the GCC backend if we can't find `libgccjit.so` for the target)
 - #157609 (fix: build-std on 32 bit arm with 64 bit time)
 - #160613 (Add regression test for unsized non-last struct field with overlapping impls)
 - #160658 (miri: implement more restrictive trivial-ABI checks)
 - #160704 (sort lint names in lint pass declarations)
 - #160707 (Add regression test for higher ranked fn pointer impl not general enough)
 - #160713 (Add regression test for #135287)
 - #160720 (triagebot: add ubiratan to infra-ci)
 - #160747 (rustc_errors: remove unused code)
 - #160751 (Add regression test for incremental borrowck ICE with generic const exprs)
 - #160753 (rustc_lint: remove unused rustc_attrs feature)

Failed merges:

 - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes
@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@folkertdev @rustbot @GuillaumeGomez @jieyouxu