rustc_errors: remove unused code - #160747
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Aug 8, 2026
Member
|
Nice, thanks! r=me once CI pass |
Collaborator
|
cc @TaKO8Ki |
rustbot
added
the
A-translation
Contributor
Author
|
@GuillaumeGomez i think I've found more :D Let's see how ci feels about it. |
Contributor
There was a problem hiding this comment.
The diagnostic items were previously used for rustc internal lints which I removed, I forgot about them, oops. I think the impl was replaced by the DiagDecorator below
@bors r=GuillaumeGomez,JonathanBrouwer rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 8, 2026
…ez,JonathanBrouwer rustc_errors: remove unused code r? @GuillaumeGomez
This was referenced Aug 8, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 8, 2026
…uwer Rollup of 12 pull requests Successful merges: - #160336 (Move attributes out of rustc_hir) - #160715 (ignore tests with the GCC backend if we can't find `libgccjit.so` for the target) - #157609 (fix: build-std on 32 bit arm with 64 bit time) - #160613 (Add regression test for unsized non-last struct field with overlapping impls) - #160658 (miri: implement more restrictive trivial-ABI checks) - #160704 (sort lint names in lint pass declarations) - #160707 (Add regression test for higher ranked fn pointer impl not general enough) - #160713 (Add regression test for #135287) - #160720 (triagebot: add ubiratan to infra-ci) - #160747 (rustc_errors: remove unused code) - #160751 (Add regression test for incremental borrowck ICE with generic const exprs) - #160753 (rustc_lint: remove unused rustc_attrs feature) Failed merges: - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)
rust-timer
added a commit
that referenced
this pull request
Aug 8, 2026
Rollup merge of #160747 - mejrs:unused_impls, r=GuillaumeGomez,JonathanBrouwer rustc_errors: remove unused code r? @GuillaumeGomez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez