Updates to dev-tc: linearization visualization, bug fixes, sync with dev branch#2990
Merged
deslaughter merged 70 commits intoOpenFAST:dev-tcfrom Sep 19, 2025
Merged
Updates to dev-tc: linearization visualization, bug fixes, sync with dev branch#2990deslaughter merged 70 commits intoOpenFAST:dev-tcfrom
deslaughter merged 70 commits intoOpenFAST:dev-tcfrom
Conversation
This reverts commit da9260b.
Multiple prescribed force timeseries files for BStC
Previously it could have called SeaSt_End multiple times, written non-fatal errors multiple times, or not called MD_End at all, depending on where an error occurred in the code.
ParseVarWDefault routines were using an optional argument as if it were not optional
This could create issues for FSI coupling. Noticed this in compilation warnings.. Consider backporting: - backport to v4.0.7 (if we do one) - backport to v4.1.3 (if we do one)
…rhandling FASTlib: missing error handling on FAST_CFD_WriteOutput
More MoorDyn Output Channels in openfast-io chans
…rectory than run directory
… into dev-tc-fixes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on updating the dev-tc branch with linearization visualization, bug fixes, and synchronization with the dev branch. It includes significant improvements to the linearization framework by adding a new VF_NoLin flag to exclude variables from linearization, fixes to BeamDyn's reaction force calculations and strain matrix storage, and various other module improvements and bug fixes.
Key changes include:
- Enhanced linearization framework with ability to exclude variables via VF_NoLin flag
- BeamDyn improvements including strain matrix storage and reaction force calculation optimization
- Various bug fixes across modules including MoorDyn, VTK reading, and numerical routines
- Documentation updates and module synchronization
Reviewed Changes
Copilot reviewed 40 out of 41 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/openfast-library/src/FAST_Solver.f90 | Added logic to clear VF_Solve flag from variables with VF_NoLin flag |
| modules/openfast-library/src/FAST_ModGlue.f90 | Enhanced linearization with VF_NoLin flag handling and fixed line indexing for BeamDyn |
| modules/openfast-library/src/FAST_Mapping.f90 | Updated custom mapping functions with destination data location parameters |
| modules/beamdyn/src/BeamDyn.f90 | Added strain matrix storage and optimized reaction force calculations |
| modules/nwtc-library/src/NWTC_Num.f90 | Performance improvements to angle adjustment and spline interpolation functions |
| modules/moordyn/src/MoorDyn*.f90 | Various bug fixes and improvements to error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mayankchetan
approved these changes
Sep 12, 2025
Contributor
mayankchetan
left a comment
mayankchetan
left a comment
There was a problem hiding this comment.
Looks good to me!
Thank you for multi blade StC and Structure only CalcSteady!! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This PR includes fixes and updates:
devbranchRelated issue, if one exists
#2553
Impacted areas of the software
devsince Merge dev branch into dev-tc #2960Test results, if applicable
No changes to existing tests.
r-testupdated for new structural controller test and synchronized todevbranch.