FIX: mne.concatenate_raws(raws) wrongly concatenates raws#11640
FIX: mne.concatenate_raws(raws) wrongly concatenates raws#11640larsoner merged 26 commits intomne-tools:mainfrom moritz-gerster:concat_raws_ch_order
Conversation
|
@moritz-gerster can you add a tiny test using simulated data? thanks |
@agramfort done. |
| Can you actually see my comments @larsoner? I am confused because my comments have the label "pending". |
|
Hello, no we don't see "pending" comments. You probably commented from the tab "Files Changed" and it added your changes as "pending" until you release the review. On the same tab, you need to press on "Review Changes" and "Submit review". The idea is that from the "Files changed" tab, you can create multiple comment and publish them all at once as a review. |
Usually that means that on the files changed tab you clicked "start a review" and made several comments but then never clicked "finish your review" |
|
+1 for checking if they match and raising an error if they don't, and providing a |
@larsoner done. |
drammock
left a comment
There was a problem hiding this comment.
Other than my detailed comments (below) one general comment is that the new test is very thorough! It might even be overkill; I'll let @larsoner decide if it needs some pruning (our current tests take a really long time to run so we are very cautious about how fast new tests run)
Co-authored-by: Daniel McCloy <dan@mccloy.info>
…ter/mne-python into concat_raws_ch_order
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
thanks @drammock! I addressed all your comments |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
|
thanks @drammock! I addressed all your comments again |
drammock
left a comment
There was a problem hiding this comment.
Looks good. I've left suggestions to disambiguate the match clauses but otherwise I'm happy. CIs are not though, but it looks unrelated (openmeeg / pyvista problems?)
drammock
left a comment
There was a problem hiding this comment.
thanks for the more robust match arguments. FYI (don't need to do this unless you want to) partial patterns like
'raws.*info.*nchan.*must match' or even just 'nchan.*must match' would have sufficed to disambiguate (with nchan / sfreq / bads substituted accordingly).
|
ci failure is this: ??? I looked at their recent commit history, nothing jumps out as an obvious culprit. |
|
Opened scipy/scipy#18377 and will push a commit to #11657 to avoid the error if I see it there, too |
|
Thanks @moritz-gerster ! |


Reference issue
Fixes #11633.