Skip to content

perf_hooks: add initiatorType getter#43593

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
RafaelGSS:fix/initiator-type-resource-timing
Jun 30, 2022
Merged

perf_hooks: add initiatorType getter#43593
nodejs-github-bot merged 1 commit intonodejs:mainfrom
RafaelGSS:fix/initiator-type-resource-timing

Conversation

@RafaelGSS
Copy link
Member

It's missing the getter for initiatorType. ref: https://w3c.github.io/resource-timing/#dfn-initiator-type

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 27, 2022
@RafaelGSS
Copy link
Member Author

cc: @nodejs/diagnostics

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 350a6a8 into nodejs:main Jun 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 350a6a8

mabaasit pushed a commit to mabaasit/node that referenced this pull request Jul 6, 2022
PR-URL: nodejs#43593
Refs: https://w3c.github.io/resource-timing/#dfn-initiator-type
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43593
Refs: https://w3c.github.io/resource-timing/#dfn-initiator-type
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43593
Refs: https://w3c.github.io/resource-timing/#dfn-initiator-type
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43593
Refs: https://w3c.github.io/resource-timing/#dfn-initiator-type
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43593
Refs: https://w3c.github.io/resource-timing/#dfn-initiator-type
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
kovan added a commit to kovan/node that referenced this pull request Mar 11, 2026
- Fix introductory ESM example that references undefined
  `doSomeLongRunningProcess` and prematurely clears marks

- Add missing PerformanceResourceTiming properties: initiatorType
  (added v18.6.0/v16.17.0 per PR nodejs#43593), nextHopProtocol,
  responseStart (added v18.2.0/v16.17.0 per PR nodejs#42725),
  deliveryType, responseStatus (added v22.2.0 per PR nodejs#51589)

- Correct PerformanceMark version metadata from v18.2.0/v16.17.0
  to v16.0.0 (introduced in PR nodejs#37136)

- Correct PerformanceMeasure version metadata from v18.2.0/v16.17.0
  to v16.7.0 (exported from module in PR nodejs#39297)

- Fix histogram.exceeds description: it counts values exceeding the
  histogram's configured `highest` value, not a "1 hour" threshold
  (verified in src/histogram-inl.h: exceeds_ increments when
  hdr_record_value returns false)

- Generalize Histogram property descriptions (min, max, mean, stddev)
  to not reference "event loop delay" since Histogram is a generic class

Fixes: nodejs#40558
Fixes: nodejs#40096
Fixes: nodejs#40723
Fixes: nodejs#55792
Fixes: nodejs#55793

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants